Skip to content

Commit 9038aa9

Browse files
committed
PR feedback
1 parent b7c18a6 commit 9038aa9

File tree

1 file changed

+6
-1
lines changed
  • packages-exp/auth-exp/src/platform_browser

1 file changed

+6
-1
lines changed

packages-exp/auth-exp/src/platform_browser/load_js.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,15 @@ function getScriptParentElement(): HTMLDocument | HTMLHeadElement {
2525
export function _loadJS(url: string): Promise<Event> {
2626
// TODO: consider adding timeout support & cancellation
2727
return new Promise((resolve, reject) => {
28+
function onError(e: Event|string): void {
29+
const errorEvent = e as ErrorEvent;
30+
const error = typeof errorEvent !== 'string' && errorEvent.error ? errorEvent.error : _createError(AuthErrorCode.INTERNAL_ERROR);
31+
reject(error);
32+
}
2833
const el = document.createElement('script');
2934
el.setAttribute('src', url);
3035
el.onload = resolve;
31-
el.onerror = () => reject(_createError(AuthErrorCode.INTERNAL_ERROR));
36+
el.onerror = onError;
3237
el.type = 'text/javascript';
3338
el.charset = 'UTF-8';
3439
getScriptParentElement().appendChild(el);

0 commit comments

Comments
 (0)