Skip to content

Commit 9175ebd

Browse files
committed
do not use g flag in regex
1 parent 36f24b1 commit 9175ebd

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

packages-exp/auth-compat-exp/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import firebase, { _FirebaseNamespace } from '@firebase/app-compat';
2121
import * as impl from '@firebase/auth-exp/internal';
22+
import * as externs from '@firebase/auth-exp';
2223
import {
2324
Component,
2425
ComponentType,
@@ -93,7 +94,7 @@ function registerAuthCompat(instance: _FirebaseNamespace): void {
9394
impl.ActionCodeOperation.REVERT_SECOND_FACTOR_ADDITION,
9495
VERIFY_AND_CHANGE_EMAIL:
9596
impl.ActionCodeOperation.VERIFY_AND_CHANGE_EMAIL,
96-
VERIFY_EMAIL: impl.ActionCodeOperation.VERIFY_EMAIL
97+
VERIFY_EMAIL: externs.ActionCodeOperation.VERIFY_EMAIL
9798
}
9899
},
99100
EmailAuthProvider: impl.EmailAuthProvider,

packages-exp/auth-compat-exp/rollup.config.shared.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ export function getEs2017Builds(additionalTypescriptPlugins = {}) {
147147

148148
export function getAllBuilds(additionalTypescriptPlugins = {}) {
149149
return [
150-
...getEs5Builds(additionalTypescriptPlugins),
150+
// ...getEs5Builds(additionalTypescriptPlugins),
151151
...getEs2017Builds(additionalTypescriptPlugins)
152152
];
153153
}

packages/firestore/rollup.config.browser.compat.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default [
3737
'browser',
3838
getImportPathTransformer({
3939
// ../../exp/index
40-
pattern: /^.*exp\/index$/g,
40+
pattern: /^.*exp\/index$/,
4141
template: ['@firebase/firestore']
4242
}),
4343
/* mangled= */ false

packages/firestore/rollup.config.node.compat.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export default [
3838
'node',
3939
getImportPathTransformer({
4040
// ../../exp/index
41-
pattern: /^.*exp\/index$/g,
41+
pattern: /^.*exp\/index$/,
4242
template: ['@firebase/firestore']
4343
})
4444
),

packages/firestore/rollup.config.rn.compat.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export default [
3434
'rn',
3535
getImportPathTransformer({
3636
// ../../exp/index
37-
pattern: /^.*exp\/index$/g,
37+
pattern: /^.*exp\/index$/,
3838
template: ['@firebase/firestore']
3939
}),
4040
/* mangled= */ false

packages/storage/rollup.config.compat.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const es5BuildPlugins = [
3939
transformers: [
4040
getImportPathTransformer({
4141
// ../exp/index
42-
pattern: /^.*exp\/api$/g,
42+
pattern: /^.*exp\/api$/,
4343
template: ['@firebase/storage']
4444
})
4545
]
@@ -80,7 +80,7 @@ const es2017BuildPlugins = [
8080
transformers: [
8181
getImportPathTransformer({
8282
// ../exp/index
83-
pattern: /^.*exp\/api$/g,
83+
pattern: /^.*exp\/api$/,
8484
template: ['@firebase/storage']
8585
})
8686
],

scripts/exp/ts-transform-import-path.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ export function getImportPathTransformer({ pattern, template }) {
3434
export const importPathTransformer = () => ({
3535
before: [
3636
transformImportPath({
37-
pattern: /^(@firebase.*)-exp(.*)$/g,
37+
pattern: /^(@firebase.*)-exp(.*)$/,
3838
template: [1, 2]
3939
})
4040
],
4141
after: [],
4242
afterDeclarations: [
4343
transformImportPath({
44-
pattern: /^(@firebase.*)-exp(.*)$/g,
44+
pattern: /^(@firebase.*)-exp(.*)$/,
4545
template: [1, 2]
4646
})
4747
]
@@ -75,7 +75,6 @@ function visitNode(node, { pattern, template }) {
7575
);
7676

7777
const captures = pattern.exec(importPath);
78-
7978
if (captures) {
8079
const newNameFragments = [];
8180
for (const fragment of template) {

0 commit comments

Comments
 (0)