remove unnecessary resumeToken test

Author: milaGGL

packages/firestore/src/core/event_manager.ts

@@ -372,7 +372,7 @@ export class QueryListener {
       return false;
     }
 
-    // Raise data from cache if we have any documents or resume token,
+    // Raise data from cache if we have any documents, have cached results before,
     // or we are offline.
     return (
       !snap.docs.isEmpty() ||

packages/firestore/test/unit/api/database.test.ts

@@ -25,8 +25,6 @@ import {
 } from '../../../src';
 import { EmulatorAuthCredentialsProvider } from '../../../src/api/credentials';
 import { User } from '../../../src/auth/user';
-import { encodeBase64 } from '../../../src/platform/base64';
-import { ByteString } from '../../../src/util/byte_string';
 import {
   collectionReference,
   documentReference,
@@ -179,48 +177,51 @@ describe('QuerySnapshot', () => {
         querySnapshot('foo', {}, { a: { a: 1 } }, keys('foo/a'), false, true)
       )
     ).to.be.false;
-  });
-
-  it('resume token should not effect querySnapshot equality', () => {
-    const resumeToken1 = ByteString.fromBase64String(
-      encodeBase64('ResumeToken1')
-    );
-    const resumeToken1Copy = ByteString.fromBase64String(
-      encodeBase64('ResumeToken1')
-    );
-    const resumeToken2 = ByteString.fromBase64String(
-      encodeBase64('ResumeToken2')
-    );
-
-    const snapshot1 = querySnapshot(
-      'foo',
-      {},
-      { a: { a: 1 } },
-      keys(),
-      false,
-      false,
-      resumeToken1
-    );
-    const snapshot1Copy = querySnapshot(
-      'foo',
-      {},
-      { a: { a: 1 } },
-      keys(),
-      false,
-      false,
-      resumeToken1Copy
-    );
-    const snapshot2 = querySnapshot(
-      'foo',
-      {},
-      { a: { a: 1 } },
-      keys(),
-      false,
-      false,
-      resumeToken2
-    );
-    expect(snapshotEqual(snapshot1, snapshot1Copy)).to.be.true;
-    expect(snapshotEqual(snapshot1, snapshot2)).to.be.true;
+    // hasCachedResults should effect querySnapshot equality
+    expect(
+      snapshotEqual(
+        querySnapshot(
+          'foo',
+          {},
+          { a: { a: 1 } },
+          keys('foo/a'),
+          false,
+          false,
+          true
+        ),
+        querySnapshot(
+          'foo',
+          {},
+          { a: { a: 1 } },
+          keys('foo/a'),
+          false,
+          false,
+          true
+        )
+      )
+    ).to.be.true;
+    expect(
+      snapshotEqual(
+        querySnapshot(
+          'foo',
+          {},
+          { a: { a: 1 } },
+          keys('foo/a'),
+          false,
+          false,
+          true
+        ),
+        querySnapshot(
+          'foo',
+          {},
+          { a: { a: 1 } },
+          keys('foo/a'),
+          false,
+          false,
+          false
+        )
+      )
+    ).to.be.false;
   });
 
   it('JSON.stringify() does not throw', () => {

packages/firestore/test/util/api_helpers.ts

@@ -43,7 +43,6 @@ import {
 import { DocumentKeySet } from '../../src/model/collections';
 import { DocumentSet } from '../../src/model/document_set';
 import { JsonObject } from '../../src/model/object_value';
-import { ByteString } from '../../src/util/byte_string';
 import { TEST_PROJECT } from '../unit/local/persistence_test_helpers';
 
 import { doc, key, path as pathFrom } from './helpers';
@@ -132,7 +131,7 @@ export function querySnapshot(
   mutatedKeys: DocumentKeySet,
   fromCache: boolean,
   syncStateChanged: boolean,
-  resumeToken?: ByteString
+  hasCachedResults?: boolean
 ): QuerySnapshot {
   const query: InternalQuery = newQueryForPath(pathFrom(path));
   let oldDocuments: DocumentSet = new DocumentSet();
@@ -155,7 +154,7 @@ export function querySnapshot(
     fromCache,
     syncStateChanged,
     false,
-    resumeToken !== undefined && resumeToken.approximateByteSize() > 0
+    hasCachedResults ?? false
   );
   const db = firestore();
   return new QuerySnapshot(