Rename _getPasswordPolicy to _getPasswordPolicyInternal

Author: ch5zzy

packages/auth/src/core/auth/auth_impl.test.ts

@@ -854,15 +854,15 @@ describe('core/auth/auth_impl', () => {
       auth.tenantId = null;
       await auth._updatePasswordPolicy();
 
-      expect(auth._getPasswordPolicy()).to.eql(CACHED_PASSWORD_POLICY);
+      expect(auth._getPasswordPolicyInternal()).to.eql(CACHED_PASSWORD_POLICY);
     });
 
     it('password policy should be set for tenant if tenant ID is not null', async () => {
       auth = await testAuth();
       auth.tenantId = TEST_TENANT_ID;
       await auth._updatePasswordPolicy();
 
-      expect(auth._getPasswordPolicy()).to.eql(
+      expect(auth._getPasswordPolicyInternal()).to.eql(
         CACHED_PASSWORD_POLICY_REQUIRE_NUMERIC
       );
     });
@@ -876,13 +876,13 @@ describe('core/auth/auth_impl', () => {
       await auth._updatePasswordPolicy();
 
       auth.tenantId = null;
-      expect(auth._getPasswordPolicy()).to.eql(CACHED_PASSWORD_POLICY);
+      expect(auth._getPasswordPolicyInternal()).to.eql(CACHED_PASSWORD_POLICY);
       auth.tenantId = TEST_TENANT_ID;
-      expect(auth._getPasswordPolicy()).to.eql(
+      expect(auth._getPasswordPolicyInternal()).to.eql(
         CACHED_PASSWORD_POLICY_REQUIRE_NUMERIC
       );
       auth.tenantId = 'other-tenant-id';
-      expect(auth._getPasswordPolicy()).to.be.undefined;
+      expect(auth._getPasswordPolicyInternal()).to.be.undefined;
     });
 
     it('password policy should not be set when the schema version is not supported', async () => {
@@ -892,7 +892,7 @@ describe('core/auth/auth_impl', () => {
         AuthErrorCode.UNSUPPORTED_PASSWORD_POLICY_SCHEMA_VERSION
       );
 
-      expect(auth._getPasswordPolicy()).to.be.undefined;
+      expect(auth._getPasswordPolicyInternal()).to.be.undefined;
     });
   });
 });

packages/auth/src/core/auth/auth_impl.ts

@@ -430,14 +430,14 @@ export class AuthImpl implements AuthInternal, _FirebaseService {
   }
 
   async validatePassword(password: string): Promise<PasswordValidationStatus> {
-    if (!this._getPasswordPolicy()) {
+    if (!this._getPasswordPolicyInternal()) {
       await this._updatePasswordPolicy();
     }
 
-    return this._getPasswordPolicy()!.validatePassword(password);
+    return this._getPasswordPolicyInternal()!.validatePassword(password);
   }
 
-  _getPasswordPolicy(): PasswordPolicyInternal | null {
+  _getPasswordPolicyInternal(): PasswordPolicyInternal | null {
     if (this.tenantId === null) {
       return this._projectPasswordPolicy;
     } else {

packages/auth/src/core/strategies/email_and_password.test.ts

@@ -807,7 +807,7 @@ describe('core/strategies/email_and_password/createUserWithEmailAndPassword', ()
       ).to.be.fulfilled;
 
       expect(policyEndpointMock.calls.length).to.eq(0);
-      expect(auth._getPasswordPolicy()).to.be.null;
+      expect(auth._getPasswordPolicyInternal()).to.be.null;
     });
 
     it('does not update the cached password policy upon successful sign up when there is an existing policy cache', async () => {
@@ -818,7 +818,7 @@ describe('core/strategies/email_and_password/createUserWithEmailAndPassword', ()
       ).to.be.fulfilled;
 
       expect(policyEndpointMock.calls.length).to.eq(1);
-      expect(auth._getPasswordPolicy()).to.eql(CACHED_PASSWORD_POLICY);
+      expect(auth._getPasswordPolicyInternal()).to.eql(CACHED_PASSWORD_POLICY);
     });
 
     context('handles password validation errors', () => {
@@ -838,7 +838,9 @@ describe('core/strategies/email_and_password/createUserWithEmailAndPassword', ()
       it('updates the cached password policy when password does not meet backend requirements', async () => {
         await auth._updatePasswordPolicy();
         expect(policyEndpointMock.calls.length).to.eq(1);
-        expect(auth._getPasswordPolicy()).to.eql(CACHED_PASSWORD_POLICY);
+        expect(auth._getPasswordPolicyInternal()).to.eql(
+          CACHED_PASSWORD_POLICY
+        );
 
         // Password policy changed after previous fetch.
         policyEndpointMock.response = PASSWORD_POLICY_RESPONSE_REQUIRE_NUMERIC;
@@ -847,34 +849,36 @@ describe('core/strategies/email_and_password/createUserWithEmailAndPassword', ()
         ).to.be.rejectedWith(FirebaseError, PASSWORD_ERROR_MSG);
 
         expect(policyEndpointMock.calls.length).to.eq(2);
-        expect(auth._getPasswordPolicy()).to.eql(
+        expect(auth._getPasswordPolicyInternal()).to.eql(
           CACHED_PASSWORD_POLICY_REQUIRE_NUMERIC
         );
       });
 
       it('does not update the cached password policy upon error if policy has not previously been fetched', async () => {
-        expect(auth._getPasswordPolicy()).to.be.null;
+        expect(auth._getPasswordPolicyInternal()).to.be.null;
 
         await expect(
           createUserWithEmailAndPassword(auth, 'some-email', 'some-password')
         ).to.be.rejectedWith(FirebaseError, PASSWORD_ERROR_MSG);
 
         expect(policyEndpointMock.calls.length).to.eq(0);
-        expect(auth._getPasswordPolicy()).to.be.null;
+        expect(auth._getPasswordPolicyInternal()).to.be.null;
       });
 
       it('does not update the cached password policy upon error if tenant changes and policy has not previously been fetched', async () => {
         auth.tenantId = TEST_TENANT_ID;
         await auth._updatePasswordPolicy();
         expect(policyEndpointMockWithTenant.calls.length).to.eq(1);
-        expect(auth._getPasswordPolicy()).to.eql(CACHED_PASSWORD_POLICY);
+        expect(auth._getPasswordPolicyInternal()).to.eql(
+          CACHED_PASSWORD_POLICY
+        );
 
         auth.tenantId = TEST_REQUIRE_NUMERIC_TENANT_ID;
         await expect(
           createUserWithEmailAndPassword(auth, 'some-email', 'some-password')
         ).to.be.rejectedWith(FirebaseError, PASSWORD_ERROR_MSG);
         expect(policyEndpointMockWithOtherTenant.calls.length).to.eq(0);
-        expect(auth._getPasswordPolicy()).to.be.undefined;
+        expect(auth._getPasswordPolicyInternal()).to.be.undefined;
       });
     });
   });

packages/auth/src/core/strategies/email_and_password.ts

@@ -313,7 +313,7 @@ export async function createUserWithEmailAndPassword(
         if (
           error.code ===
             `auth/${AuthErrorCode.PASSWORD_DOES_NOT_MEET_REQUIREMENTS}` &&
-          authInternal._getPasswordPolicy()
+          authInternal._getPasswordPolicyInternal()
         ) {
           await authInternal._updatePasswordPolicy();
         }

packages/auth/src/model/auth.ts

@@ -88,7 +88,7 @@ export interface AuthInternal extends Auth {
   _stopProactiveRefresh(): void;
   _getPersistence(): string;
   _getRecaptchaConfig(): RecaptchaConfig | null;
-  _getPasswordPolicy(): PasswordPolicyInternal | null;
+  _getPasswordPolicyInternal(): PasswordPolicyInternal | null;
   _updatePasswordPolicy(): Promise<void>;
   _logFramework(framework: string): void;
   _getFrameworks(): readonly string[];