Fix tests

Author: mmermerkaya

packages/database/src/core/snap/nodeFromJSON.ts

@@ -70,8 +70,8 @@ export function nodeFromJSON(
     const children: NamedNode[] = [];
     let childrenHavePriority = false;
     const hinzeJsonObj: { [k: string]: any } = json;
-    each(hinzeJsonObj, (key: string, child: any) => {
-      if (typeof key !== 'string' || key.substring(0, 1) !== '.') {
+    each(hinzeJsonObj, (key, child) => {
+      if (key.substring(0, 1) !== '.') {
         // Ignore metadata nodes
         const childNode = nodeFromJSON(child);
         if (!childNode.isEmpty()) {

packages/database/src/core/util/util.ts

@@ -394,22 +394,16 @@ export const splitStringBySize = function(
  * @param obj The object or array to iterate over
  * @param fn The function to apply
  */
-export function each(obj: object | Array<any>, fn: (v: any, k: any) => void) {
-  if (Array.isArray(obj)) {
-    for (let i = 0; i < obj.length; ++i) {
-      fn(i, obj[i]);
-    }
-  } else {
-    /**
-     * in the conversion of code we removed the goog.object.forEach
-     * function which did a value,key callback. We standardized on
-     * a single impl that does a key, value callback. So we invert
-     * to not have to touch the `each` code points
-     */
-    for (const key in obj) {
-      if (obj.hasOwnProperty(key)) {
-        fn(obj[key], key);
-      }
+export function each(obj: object, fn: (k: string, v: any) => void) {
+  /**
+   * in the conversion of code we removed the goog.object.forEach
+   * function which did a value,key callback. We standardized on
+   * a single impl that does a key, value callback. So we invert
+   * to not have to touch the `each` code points
+   */
+  for (const key in obj) {
+    if (obj.hasOwnProperty(key)) {
+      fn(key, obj[key]);
     }
   }
 }

packages/database/src/realtime/TransportManager.ts

@@ -70,14 +70,11 @@ export class TransportManager {
       this.transports_ = [WebSocketConnection];
     } else {
       const transports = (this.transports_ = [] as TransportConstructor[]);
-      each(
-        TransportManager.ALL_TRANSPORTS,
-        (i: number, transport: TransportConstructor) => {
-          if (transport && transport['isAvailable']()) {
-            transports.push(transport);
-          }
+      for (const transport of TransportManager.ALL_TRANSPORTS) {
+        if (transport && transport['isAvailable']()) {
+          transports.push(transport);
         }
-      );
+      }
     }
   }