removing debug logs

Author: bhparijat

packages/auth/package.json

@@ -118,7 +118,8 @@
     "rollup": "2.72.1",
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.2.2",
+    "totp-generator": "0.0.14"
   },
   "repository": {
     "directory": "packages/auth",

packages/auth/test/helpers/integration/helpers.ts

@@ -62,8 +62,6 @@ export function getTestInstance(requireEmulator = false): Auth {
 
   auth.cleanUp = async () => {
     // If we're in an emulated environment, the emulator will clean up for us
-
-    console.log('Auth cleanup should not be called');
     if (emulatorUrl) {
       await resetEmulator();
     } else {
@@ -107,8 +105,6 @@ function stubConsoleToSilenceEmulatorWarnings(): sinon.SinonStub {
 
 export async function code(toEmail: string): Promise<OobCodeSession> {
   const codes = await getOobCodes();
-  console.log('codes: ', codes);
-
   return codes.reverse().find(({ email }) => email === toEmail)!;
 }
 
@@ -124,8 +120,6 @@ return token
 
 export function delay(dt:number){
 
-  console.log('Delay called');
- 
   return  new Promise(resolve => setTimeout(resolve, dt));
 }
 

packages/auth/test/integration/flows/totp.test.ts

@@ -17,32 +17,22 @@
 
  import { expect, use } from 'chai';
  import chaiAsPromised from 'chai-as-promised';
- import * as sinon from 'sinon';
  import sinonChai from 'sinon-chai';
 
 //import { mockTotp } from '../../helpers/integration/helpers';
-import {Auth, createUserWithEmailAndPassword, multiFactor, signInWithEmailAndPassword, UserCredential, sendEmailVerification, applyActionCode, getMultiFactorResolver} from '@firebase/auth';
+import {Auth, createUserWithEmailAndPassword, multiFactor, signInWithEmailAndPassword, UserCredential, getMultiFactorResolver} from '@firebase/auth';
 import { FirebaseError, getApp } from '@firebase/app';
 import {
   cleanUpTestInstance,
-  code,
   getTestInstance,
   getTotpCode,
   delay,
-  randomEmail,
-  verifyEmail,
   email
 } from '../../helpers/integration/helpers';
 import { MultiFactorAssertionImpl } from '../../../src/mfa/mfa_assertion';
 
-import { MultiFactorSessionImpl } from '../../../src/mfa/mfa_session';
 import { TotpMultiFactorGenerator, TotpSecret } from '../../../src/mfa/assertions/totp';
 import * as MFA from '../../../src/api/account_management/mfa';
-import { async } from '@firebase/util';
-import { UserCredentialImpl } from '../../../src/core/user/user_credential_impl';
-import { resolve } from 'dns';
-import { UserCredentialInternal } from '../../../internal';
-import { verify } from 'crypto';
 
 
 
@@ -72,87 +62,45 @@ describe(' Integration tests: Mfa TOTP', () => {
 
   it('should not enroll if incorrect totp supplied', async () => {
     let session;
-    console.log(email);
-    console.log('session info for: ', getApp().options.projectId);
-    console.log('auth current User:', auth.currentUser);  
-
-    await expect(createUserWithEmailAndPassword(auth, email, 'password')).to.be.rejectedWith('auth/email-already-in-use');
+    //await expect(createUserWithEmailAndPassword(auth, email, 'password')).to.be.rejectedWith('auth/email-already-in-use');
 
     const cr = await signInWithEmailAndPassword(auth, email, 'password');
-
-    console.log('signed In for totp');
     const mfaUser =  multiFactor(cr.user);
-
-    console.log('session info for: ');
     session =  await mfaUser.getSession();
-    console.log(JSON.stringify(session));
-    
-    
     totpSecret = await TotpMultiFactorGenerator.generateSecret(
       session
     );
-
-    console.log("**** totpSecret****");
-    console.log(totpSecret.secretKey);
-    console.log(totpSecret.codeLength);
-    console.log(totpSecret.codeIntervalSeconds);
-    console.log(totpSecret.hashingAlgorithm);
-
     const totpVerificationCode =  getTotpCode(totpSecret.secretKey, totpSecret.codeIntervalSeconds, totpSecret.codeLength,  totpSecret.hashingAlgorithm);
 
     const multiFactorAssertion = TotpMultiFactorGenerator.assertionForEnrollment(
       totpSecret,
       totpVerificationCode + '0'
     );
 
-    console.log(totpVerificationCode);
     await expect(mfaUser.enroll(multiFactorAssertion, displayName)).to.be.rejectedWith('auth/invalid-verification-code');
     await auth.signOut();
   })
     it('should enroll using correct otp', async () => {
 
       let session;
-      console.log(email);
-      console.log('session info for: ', getApp().options.projectId);
-      console.log('auth current User:', auth.currentUser);  
-      await expect(createUserWithEmailAndPassword(auth, email, 'password')).to.be.rejectedWith('auth/email-already-in-use');
+      //await expect(createUserWithEmailAndPassword(auth, email, 'password')).to.be.rejectedWith('auth/email-already-in-use');
       const cr = await signInWithEmailAndPassword(auth, email, 'password');
 
-      console.log('signed In for totp');
       const mfaUser =  multiFactor(cr.user);
-      
-      console.log('session info for: ');
-
-
+     
       session =  await mfaUser.getSession();
 
 
-      console.log('session');
-      console.log(JSON.stringify(session));
-      
-      
       totpSecret = await TotpMultiFactorGenerator.generateSecret(
         session
       );
-
-      console.log("**** totpSecret****");
-
-      console.log(totpSecret.secretKey);
-      console.log(totpSecret.codeLength);
-      console.log(totpSecret.codeIntervalSeconds);
-      console.log(totpSecret.hashingAlgorithm);
-
-
-     
 
       const totpVerificationCode = getTotpCode(totpSecret.secretKey, totpSecret.codeIntervalSeconds, totpSecret.codeLength,  totpSecret.hashingAlgorithm);
 
       const multiFactorAssertion = TotpMultiFactorGenerator.assertionForEnrollment(
         totpSecret,
         totpVerificationCode
       );
-      console.log(totpVerificationCode);
-   
       await expect(mfaUser.enroll(multiFactorAssertion, displayName)).to.be.fulfilled;
 
       await auth.signOut();
@@ -163,38 +111,28 @@ describe(' Integration tests: Mfa TOTP', () => {
       let session;
       let cr;
       let resolver;
-      console.log(email);
-      console.log('session info for: ', getApp().options.projectId);
-      await expect(createUserWithEmailAndPassword(auth, email, 'password')).to.be.rejectedWith('auth/email-already-in-use');
+      //await expect(createUserWithEmailAndPassword(auth, email, 'password')).to.be.rejectedWith('auth/email-already-in-use');
       // Added a delay so that getTotpCode() actually generates a new totp code 
       await delay(30*1000);
       try{
 
         const userCredential = await signInWithEmailAndPassword(auth, email, 'password');
 
-        console.log('success: ', userCredential);
-        
         throw new Error('Signin should not have been successful');
 
       } catch(error ){
 
 
-        console.log('error occured: ', (error as any).code);
         expect((error as any).code).to.eql('auth/multi-factor-auth-required');
 
         resolver = getMultiFactorResolver(auth,error as any);
-        console.log(resolver.hints, totpSecret.secretKey);
         expect(resolver.hints).to.have.length(1);
 
         const totpVerificationCode = getTotpCode(totpSecret.secretKey, totpSecret.codeIntervalSeconds, totpSecret.codeLength,  totpSecret.hashingAlgorithm);
-        console.log(totpVerificationCode, resolver.hints[0].uid )
         const assertion = TotpMultiFactorGenerator.assertionForSignIn(
           resolver.hints[0].uid,
           totpVerificationCode + '0'
         );
-
-        console.log(assertion);
-
 
         await expect(resolver.resolveSignIn(assertion)).to.be.rejectedWith('auth/invalid-verification-code');
 
@@ -209,40 +147,31 @@ describe(' Integration tests: Mfa TOTP', () => {
 
       let resolver;
 
-      console.log(email);
-      console.log('session info for: ', getApp().options.projectId);
-      
-      await expect(createUserWithEmailAndPassword(auth, email, 'password')).to.be.rejectedWith('auth/email-already-in-use');
-      // Added a delay so that getTotpCode() actually generates a new totp code
       await delay(30*1000);
+
+      //await expect(createUserWithEmailAndPassword(auth, email, 'password')).to.be.rejectedWith('auth/email-already-in-use');
+      // Added a delay so that getTotpCode() actually generates a new totp code
+      
       try{
 
         const userCredential = await signInWithEmailAndPassword(auth, email, 'password');
 
-        console.log('success: ', userCredential);
 
         throw new Error('Signin should not have been successful');
 
       } catch(error ){
 
-        
-        console.log('error occured: ', (error as any).code);
+        expect(error).to.be.an.instanceOf(FirebaseError);
         expect((error as any).code).to.eql('auth/multi-factor-auth-required');
 
         resolver = getMultiFactorResolver(auth,error as any);
-        console.log(resolver.hints, totpSecret.secretKey);
         expect(resolver.hints).to.have.length(1);
 
         const totpVerificationCode = getTotpCode(totpSecret.secretKey, totpSecret.codeIntervalSeconds, totpSecret.codeLength,  totpSecret.hashingAlgorithm);
-        console.log(totpVerificationCode, resolver.hints[0].uid )
         const assertion = TotpMultiFactorGenerator.assertionForSignIn(
           resolver.hints[0].uid,
           totpVerificationCode 
-        );
-
-        console.log(assertion);
-
-        
+        );        
         const userCredential = await resolver.resolveSignIn(assertion);
 
         const mfaUser = multiFactor(userCredential.user);