Make ordering for BooleanValues explicit (#2675)

schmidt-sebastian · web-flow · commit 94e2eadb7146 · 2020-02-24T20:05:00.000-08:00
diff --git a/packages/firestore/src/model/field_value.ts b/packages/firestore/src/model/field_value.ts
@@ -203,7 +203,7 @@ export class BooleanValue extends FieldValue {
 
   compareTo(other: FieldValue): number {
     if (other instanceof BooleanValue) {
-      return primitiveComparator(this, other);
+      return primitiveComparator(this.internalValue, other.internalValue);
     }
     return this.defaultCompareTo(other);
   }

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ export class BooleanValue extends FieldValue {`
`203`	`203`
`204`	`204`	`compareTo(other: FieldValue): number {`
`205`	`205`	`if (other instanceof BooleanValue) {`
`206`		`- return primitiveComparator(this, other);`
	`206`	`+ return primitiveComparator(this.internalValue, other.internalValue);`
`207`	`207`	`}`
`208`	`208`	`return this.defaultCompareTo(other);`
`209`	`209`	`}`