rename delete to _delete

Author: Feiyang1

packages-exp/app-types-exp/index.d.ts

@@ -113,7 +113,7 @@ export interface _FirebaseService {
    * Delete the service and free it's resources - called from
    * {@link @firebase/app-exp#deleteApp | deleteApp()}
    */
-  delete(): Promise<void>;
+  _delete(): Promise<void>;
 }
 
 export interface VersionService {

packages/component/src/provider.test.ts

@@ -232,7 +232,7 @@ describe('Provider', () => {
         const deleteFake = fake();
         const myService: _FirebaseService = {
           app: getFakeApp(),
-          delete: deleteFake
+          _delete: deleteFake
         };
 
         // provide factory and create a service instance

packages/component/src/provider.ts

@@ -176,18 +176,9 @@ export class Provider<T extends Name> {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         .map(service => (service as any).INTERNAL!.delete()),
       ...services
-        .filter(
-          service =>
-            'delete' in service &&
-            this.component &&
-            // TODO: remove !== 'app' when modular SDKs become official
-            // People call app.delete() to trigger provider.delete() for all registered components, so
-            // we don't call delete() on legacy FirebaseApp to avoid getting into a loop.
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            (this.component.name as any) !== 'app'
-        ) // modular services
+        .filter(service => '_delete' in service) // modularized services
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        .map(service => (service as any).delete())
+        .map(service => (service as any)._delete())
     ]);
   }
 

packages/firestore/exp/src/api/components.ts

@@ -71,7 +71,7 @@ export async function setOfflineComponentProvider(
   // When a user calls clearPersistence() in one client, all other clients
   // need to be terminated to allow the delete to succeed.
   offlineComponentProvider.persistence.setDatabaseDeletedListener(() =>
-    firestore.delete()
+    firestore._delete()
   );
   offlineDeferred.resolve(offlineComponentProvider);
 }

packages/firestore/exp/src/api/database.ts

@@ -306,7 +306,7 @@ export function terminate(
 ): Promise<void> {
   _removeServiceInstance(firestore.app, 'firestore-exp');
   const firestoreImpl = cast(firestore, Firestore);
-  return firestoreImpl.delete();
+  return firestoreImpl._delete();
 }
 
 function verifyNotInitialized(firestore: Firestore): void {

packages/firestore/lite/src/api/database.ts

@@ -95,7 +95,7 @@ export class Firestore
     return new DatabaseId(app.options.projectId!);
   }
 
-  delete(): Promise<void> {
+  _delete(): Promise<void> {
     if (!this._terminateTask) {
       this._terminateTask = this._terminate();
     }
@@ -117,7 +117,7 @@ export class Firestore
   // TODO(firestoreexp): `deleteApp()` should call the delete method above,
   // but it still calls INTERNAL.delete().
   INTERNAL = {
-    delete: () => this.delete()
+    delete: () => this._delete()
   };
 }
 
@@ -142,5 +142,5 @@ export function terminate(
 ): Promise<void> {
   _removeServiceInstance(firestore.app, 'firestore/lite');
   const firestoreClient = cast(firestore, Firestore);
-  return firestoreClient.delete();
+  return firestoreClient._delete();
 }