Bugs

Author: schmidt-sebastian

packages/database/src/core/WriteTree.ts

@@ -24,6 +24,7 @@ import {
   pathChild,
   pathContains,
   pathGetFront,
+  pathIsEmpty,
   pathPopFront
 } from './util/Path';
 import {
@@ -570,7 +571,7 @@ export class WriteTree {
       // b) not be relevant to a transaction (separate branch), so again will not affect the data for that transaction
       if (filter(write)) {
         const writePath = write.path;
-        let relativePath;
+        let relativePath: Path;
         if (write.snap) {
           if (pathContains(treeRoot, writePath)) {
             relativePath = newRelativePath(treeRoot, writePath);
@@ -599,7 +600,7 @@ export class WriteTree {
             );
           } else if (pathContains(writePath, treeRoot)) {
             relativePath = newRelativePath(writePath, treeRoot);
-            if (relativePath.isEmpty()) {
+            if (pathIsEmpty(relativePath)) {
               compoundWrite = compoundWriteAddWrites(
                 compoundWrite,
                 newEmptyPath(),

packages/database/src/core/util/validation.ts

@@ -22,6 +22,7 @@ import {
   pathContains,
   pathGetBack,
   pathGetFront,
+  pathSlice,
   ValidationPath
 } from './Path';
 import {
@@ -199,10 +200,10 @@ export const validateFirebaseMergePaths = function (
   errorPrefix: string,
   mergePaths: Path[]
 ) {
-  let i, curPath;
+  let i, curPath: Path;
   for (i = 0; i < mergePaths.length; i++) {
     curPath = mergePaths[i];
-    const keys = curPath.slice();
+    const keys = pathSlice(curPath);
     for (let j = 0; j < keys.length; j++) {
       if (keys[j] === '.priority' && j === keys.length - 1) {
         // .priority is OK