Addressing PR comments

Author: hsubox76

packages/app/src/firebaseApp.ts

@@ -116,9 +116,7 @@ export class FirebaseAppImpl implements FirebaseApp {
         return Promise.all(
           services
             .filter(service => 'INTERNAL' in service)
-            .map(service => {
-              return service.INTERNAL!.delete();
-            })
+            .map(service => service.INTERNAL!.delete())
         );
       })
       .then(

packages/app/src/lite/firebaseAppLite.ts

@@ -96,11 +96,9 @@ export class FirebaseAppLiteImpl implements FirebaseApp {
         }
 
         return Promise.all(
-          services.map(service => {
-            return service.INTERNAL
-              ? service.INTERNAL.delete()
-              : Promise.resolve();
-          })
+          services
+            .filter(service => 'INTERNAL' in service)
+            .map(service => service.INTERNAL!.delete())
         );
       })
       .then(

packages/rxfire/database/list/index.ts

@@ -18,7 +18,7 @@
 import { database } from 'firebase';
 import { QueryChange, ListenEvent } from '../interfaces';
 import { Observable, of, merge, from } from 'rxjs';
-import { validateEventsArray, isNil } from '../utils';
+import { validateEventsArray } from '../utils';
 import { fromRef } from '../fromRef';
 import { switchMap, scan, distinctUntilChanged, map } from 'rxjs/operators';
 import { changeToData } from '../object';
@@ -80,7 +80,7 @@ function positionFor(changes: QueryChange[], key) {
 }
 
 function positionAfter(changes: QueryChange[], prevKey?: string) {
-  if (isNil(prevKey)) {
+  if (prevKey == null) {
     return 0;
   } else {
     const i = positionFor(changes, prevKey);

packages/rxfire/database/utils.ts

@@ -17,17 +17,13 @@
 
 import { ListenEvent } from './interfaces';
 
-export function isNil(obj: any): obj is null | undefined {
-  return obj === undefined || obj === null;
-}
-
 /**
  * Check the length of the provided array. If it is empty return an array
  * that is populated with all the Realtime Database child events.
  * @param events
  */
 export function validateEventsArray(events?: ListenEvent[]): ListenEvent[] {
-  if (isNil(events) || events!.length === 0) {
+  if (events == null || events!.length === 0) {
     events = [
       ListenEvent.added,
       ListenEvent.removed,

packages/storage/src/implementation/requests.ts

@@ -332,14 +332,14 @@ export function createResumableUpload(
 ): RequestInfo<string> {
   let urlPart = location.bucketOnlyServerUrl();
   let metadata = metadataForUpload_(location, blob, opt_metadata);
-  let urlParams: UrlParams = { name: metadata['fullPath'] || '' };
+  let urlParams: UrlParams = { name: metadata['fullPath']! };
   let url = UrlUtils.makeUrl(urlPart);
   let method = 'POST';
   let headers = {
     'X-Goog-Upload-Protocol': 'resumable',
     'X-Goog-Upload-Command': 'start',
     'X-Goog-Upload-Header-Content-Length': blob.size(),
-    'X-Goog-Upload-Header-Content-Type': metadata['contentType'] || '',
+    'X-Goog-Upload-Header-Content-Type': metadata['contentType']!,
     'Content-Type': 'application/json; charset=utf-8'
   };
   let body = MetadataUtils.toResourceString(metadata, mappings);