Added spec tests.

Two TODO:
1. load from secondary tab.
2. don't fail async queue.

Author: wu-hui

packages/firestore/src/core/sync_engine.ts

@@ -447,9 +447,15 @@ export class SyncEngine implements RemoteSyncer {
   ): Promise<void> {
     this.assertSubscribed('loadBundle()');
 
-    return this.loadBundleAsync(bundleReader, task).catch(reason => {
-      task.failedWith(new Error(reason));
-    });
+    return (
+      this.loadBundleAsync(bundleReader, task)
+        // TODO(wuandy): Loading a bundle will fail the entire SDK if there is
+        // an error. We really should have a way to run operations on async queue
+        // and not failing the rest if there is an error.
+        .catch(reason => {
+          task.failedWith(reason);
+        })
+    );
   }
 
   private async loadBundleAsync(
@@ -1323,4 +1329,11 @@ export class MultiTabSyncEngine extends SyncEngine
         .catch(ignoreIfPrimaryLeaseLoss);
     }
   }
+
+  loadBundle(
+    bundleReader: BundleReader,
+    task: LoadBundleTaskImpl
+  ): Promise<void> {
+    return super.loadBundle(bundleReader, task);
+  }
 }

packages/firestore/src/local/local_store.ts

@@ -646,7 +646,7 @@ export class LocalStore {
     });
     return this.persistence.runTransaction(
       'Apply bundle documents',
-      'readwrite-primary',
+      'readwrite',
       txn => {
         return this.applyDocuments(
           documentBuffer,

packages/firestore/test/integration/api/bundle.test.ts

@@ -17,7 +17,12 @@
 
 import * as firestore from '@firebase/firestore-types';
 import { expect } from 'chai';
-import { apiDescribe, toDataArray, withTestDb } from '../util/helpers';
+import {
+  apiDescribe,
+  toDataArray,
+  withAlternateTestDb,
+  withTestDb
+} from '../util/helpers';
 import { TestBundleBuilder } from '../../util/bundle_data';
 import { DatabaseId } from '../../../src/core/database_info';
 import { key } from '../../util/helpers';
@@ -40,7 +45,7 @@ function verifyInProgress(
   expect(p.documentsLoaded).to.equal(expectedDocuments);
 }
 
-apiDescribe.only('Bundles', (persistence: boolean) => {
+apiDescribe('Bundles', (persistence: boolean) => {
   const encoder = new TextEncoder();
   const testDocs: { [key: string]: firestore.DocumentData } = {
     a: { k: { stringValue: 'a' }, bar: { integerValue: 1 } },
@@ -224,4 +229,20 @@ apiDescribe.only('Bundles', (persistence: boolean) => {
       ]);
     });
   });
+
+  it('load with documents from other projects fails.', () => {
+    return withTestDb(persistence, async db => {
+      const builder = bundleWithTestDocs(db);
+      return withAlternateTestDb(persistence, async otherDb => {
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
+        expect(
+          otherDb.loadBundle(
+            encoder.encode(
+              builder.build('test-bundle', { seconds: 1001, nanos: 9999 })
+            )
+          )
+        ).to.be.rejectedWith('Tried to deserialize key from different project');
+      });
+    });
+  });
 });