Skip to content

Commit 97cc6a0

Browse files
Wait for all Promises in deleteApp()
Pretty sure this is causes the CI failure in #3382
1 parent 45101dd commit 97cc6a0

File tree

1 file changed

+5
-3
lines changed
  • packages-exp/app-exp/src

1 file changed

+5
-3
lines changed

packages-exp/app-exp/src/api.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,11 @@ export async function deleteApp(app: FirebaseApp): Promise<void> {
213213
const name = app.name;
214214
if (_apps.has(name)) {
215215
_apps.delete(name);
216-
await (app as _FirebaseAppInternal).container
217-
.getProviders()
218-
.map(provider => provider.delete());
216+
await Promise.all(
217+
(app as _FirebaseAppInternal).container
218+
.getProviders()
219+
.map(provider => provider.delete())
220+
);
219221
(app as _FirebaseAppInternal).isDeleted = true;
220222
}
221223
}

0 commit comments

Comments
 (0)