Address PR comments

Author: hsubox76

packages/storage/compat/task.ts

@@ -31,16 +31,21 @@ import { ReferenceCompat } from './reference';
 import { FirebaseStorageError } from '../src/implementation/error';
 
 export class UploadTaskCompat implements types.UploadTask {
+  private readonly _snapshot: UploadTaskSnapshotCompat;
   constructor(
     private readonly _delegate: UploadTask,
     private readonly _ref: ReferenceCompat
-  ) {}
+  ) {
+    this._snapshot = new UploadTaskSnapshotCompat(
+      this._delegate.snapshot,
+      this,
+      this._ref
+    );
+  }
 
-  snapshot = new UploadTaskSnapshotCompat(
-    this._delegate.snapshot,
-    this,
-    this._ref
-  );
+  get snapshot(): UploadTaskSnapshotCompat {
+    return this._snapshot;
+  }
 
   cancel = this._delegate.cancel.bind(this._delegate);
   catch = this._delegate.catch.bind(this._delegate);
@@ -73,21 +78,20 @@ export class UploadTaskCompat implements types.UploadTask {
       | StorageObserver<UploadTaskSnapshot>
       | undefined
       | ((a: UploadTaskSnapshot) => unknown) = undefined;
-    if (nextOrObserver != null) {
+    if (!!nextOrObserver) {
       if (typeof nextOrObserver === 'function') {
         wrappedNextOrObserver = (taskSnapshot: UploadTaskSnapshot) =>
           nextOrObserver(
             new UploadTaskSnapshotCompat(taskSnapshot, this, this._ref)
           );
       } else {
         wrappedNextOrObserver = {
-          next:
-            nextOrObserver.next == null
-              ? undefined
-              : (taskSnapshot: UploadTaskSnapshot) =>
-                  nextOrObserver.next!(
-                    new UploadTaskSnapshotCompat(taskSnapshot, this, this._ref)
-                  ),
+          next: !!nextOrObserver.next
+            ? (taskSnapshot: UploadTaskSnapshot) =>
+                nextOrObserver.next!(
+                  new UploadTaskSnapshotCompat(taskSnapshot, this, this._ref)
+                )
+            : undefined,
           complete: nextOrObserver.complete || undefined,
           error: nextOrObserver.error || undefined
         };

packages/storage/src/implementation/error.ts

@@ -222,30 +222,8 @@ export function noDownloadURL(): FirebaseStorageError {
   );
 }
 
-export function invalidArgument(message: string): FirebaseStorageError;
-export function invalidArgument(
-  index: number,
-  fnName: string,
-  message: string
-): FirebaseStorageError;
-export function invalidArgument(
-  indexOrMessage: number | string,
-  fnName?: string,
-  message?: string
-): FirebaseStorageError {
-  if (typeof indexOrMessage === 'string') {
-    return new FirebaseStorageError(Code.INVALID_ARGUMENT, indexOrMessage);
-  } else {
-    return new FirebaseStorageError(
-      Code.INVALID_ARGUMENT,
-      'Invalid argument in `' +
-        fnName +
-        '` at index ' +
-        indexOrMessage +
-        ': ' +
-        message
-    );
-  }
+export function invalidArgument(message: string): FirebaseStorageError {
+  return new FirebaseStorageError(Code.INVALID_ARGUMENT, message);
 }
 
 export function invalidArgumentCount(

packages/storage/src/implementation/location.ts

@@ -23,9 +23,6 @@
 import { invalidDefaultBucket, invalidUrl } from './error';
 import { DEFAULT_HOST } from './constants';
 
-/**
- * @public
- */
 export class Location {
   private path_: string;
 

packages/storage/src/implementation/string.ts

@@ -28,9 +28,6 @@ export const StringFormat = {
   DATA_URL: 'data_url'
 };
 
-/**
- * @internal
- */
 export class StringData {
   contentType: string | null;
 

packages/storage/src/reference.ts

@@ -35,11 +35,7 @@ import { Metadata } from './metadata';
 import { StorageService } from './service';
 import { ListOptions, ListResult } from './list';
 import { UploadTask } from './task';
-import {
-  invalidArgument,
-  invalidRootOperation,
-  noDownloadURL
-} from './implementation/error';
+import { invalidRootOperation, noDownloadURL } from './implementation/error';
 import { validateNumber } from './implementation/type';
 
 /**
@@ -155,13 +151,6 @@ export function uploadString(
   format: StringFormat = StringFormat.RAW,
   metadata?: Metadata
 ): UploadTask {
-  if (typeof value !== 'string') {
-    throw invalidArgument(
-      1,
-      'uploadString',
-      'Must provide a string to upload.'
-    );
-  }
   ref._throwIfRoot('putString');
   const data = dataFromString(format, value);
   const metadataClone = { ...metadata } as Metadata;