Fix tests and lint errors

Author: mmermerkaya

packages/database/src/api/test_access.ts

@@ -83,14 +83,6 @@ export const queryIdentifier = function(query: Query) {
   return query.queryIdentifier();
 };
 
-/**
- * @param {!Query} firebaseRef
- * @return {!Object}
- */
-export const listens = function(firebaseRef: Query) {
-  return (firebaseRef.repo.persistentConnection_ as any).listens_;
-};
-
 /**
  * Forces the RepoManager to create Repos that use ReadonlyRestClient instead of PersistentConnection.
  *

packages/database/test/query.test.ts

@@ -1575,10 +1575,11 @@ describe('Query Tests', function() {
   });
 
   function dumpListens(node: Query) {
-    const listens = (node.repo.persistentConnection_ as any).listens_;
+    const listens: Map<string, Map<string, unknown>> = (node.repo
+      .persistentConnection_ as any).listens;
     const nodePath = getPath(node);
     const listenPaths = [];
-    for (let path in listens) {
+    for (let path of listens.keys()) {
       if (path.substring(0, nodePath.length) === nodePath) {
         listenPaths.push(path);
       }
@@ -1588,7 +1589,7 @@ describe('Query Tests', function() {
     const dumpPieces = [];
     for (let i = 0; i < listenPaths.length; i++) {
       const queryIds = [];
-      for (let queryId in listens[listenPaths[i]]) {
+      for (let queryId of listens.get(listenPaths[i]).keys()) {
         queryIds.push(queryId);
       }
       queryIds.sort();

packages/util/src/obj.ts

@@ -45,12 +45,12 @@ export function isEmpty(obj: object): obj is {} {
 export function map<T extends object, V, U extends { [key in keyof T]: V }>(
   obj: T,
   fn: (value: Values<T>, key: Keys<T>, obj: T) => V,
-  opt_obj?: unknown
+  contextObj?: unknown
 ): U {
   const res: Partial<U> = {};
   for (const key in obj) {
     if (Object.prototype.hasOwnProperty.call(obj, key)) {
-      res[key] = fn.call(opt_obj, obj[key], key, obj);
+      res[key] = fn.call(contextObj, obj[key], key, obj);
     }
   }
   return res as U;

packages/util/src/query.ts

@@ -20,8 +20,10 @@
  * params object (e.g. {arg: 'val', arg2: 'val2'})
  * Note: You must prepend it with ? when adding it to a URL.
  */
-export function querystring(querystringParams: { [key: string]: string }) {
-  var params = [];
+export function querystring(querystringParams: {
+  [key: string]: string;
+}): string {
+  const params = [];
   for (const [key, value] of Object.entries(querystringParams)) {
     if (Array.isArray(value)) {
       value.forEach(arrayVal => {