Skip to content

Commit 99c4ea4

Browse files
committed
Combine tag/version inputs
1 parent bc02dd1 commit 99c4ea4

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

.github/workflows/e2e-test.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,9 @@ name: E2E Smoke Tests
44
on:
55
workflow_dispatch:
66
inputs:
7-
version:
8-
description: 'release version'
9-
required: false
10-
default: 'unknown'
11-
tag:
12-
description: '@tag to install'
13-
required: false
7+
versionOrTag:
8+
description: 'release version or tag'
9+
required: true
1410
default: 'next'
1511

1612
jobs:
@@ -43,8 +39,8 @@ jobs:
4339
echo "export const config = $PROJECT_CONFIG; export const testAccount = $TEST_ACCOUNT" > firebase-config.js
4440
- name: Yarn install
4541
run: |
46-
echo "Installing firebase@${{ github.event.inputs.tag }}"
47-
yarn add firebase@${{ github.event.inputs.tag }}
42+
echo "Installing firebase@${{ github.event.inputs.versionOrTag }}"
43+
yarn add firebase@${{ github.event.inputs.versionOrTag }}
4844
yarn
4945
- name: Deploy "callTest" cloud function
5046
run: |

scripts/ci/notify-test-result.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ async function notifyTestResults() {
4242
// Add version if it can find it in the workflow_dispatch event data.
4343
if (process.env.GITHUB_EVENT_PATH) {
4444
const wrPayload = require(process.env.GITHUB_EVENT_PATH);
45-
if (wrPayload.inputs && wrPayload.inputs.version) {
46-
message += ` for release ${wrPayload.inputs.version}.`;
45+
if (wrPayload.inputs && wrPayload.inputs.versionOrTag) {
46+
message += ` for release ${wrPayload.inputs.versionOrTag}.`;
4747
} else {
48-
console.log(`Couldn't find version in event payload.`);
48+
console.log(`Couldn't find versionOrTag in event payload.`);
4949
}
5050
} else {
5151
console.log(`Couldn't find event payload.`);

0 commit comments

Comments
 (0)