Skip to content

Commit 99ee5b6

Browse files
authored
Add exp deps and fix script bug (#4322)
1 parent b955788 commit 99ee5b6

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages-exp/firebase-exp/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,11 @@
3636
"test:ci": "echo 'No test suite for firebase wrapper'"
3737
},
3838
"dependencies": {
39+
"@firebase/analytics-exp": "0.0.900",
3940
"@firebase/app-exp": "0.0.900",
4041
"@firebase/app-compat": "0.0.900",
4142
"@firebase/auth-exp": "0.0.900",
43+
"@firebase/database": "0.8.3",
4244
"@firebase/functions-exp": "0.0.900",
4345
"@firebase/firestore": "2.1.2",
4446
"@firebase/storage": "0.4.2",

scripts/exp/release.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ async function publishExpPackages({ dryRun }: { dryRun: boolean }) {
146146
* Do not push to remote if it's a dryrun
147147
*/
148148
if (!dryRun) {
149-
const { commitAndPush } = await prompt([
149+
const { shouldCommitAndPush } = await prompt([
150150
{
151151
type: 'confirm',
152152
name: 'commitAndPush',
@@ -158,7 +158,7 @@ async function publishExpPackages({ dryRun }: { dryRun: boolean }) {
158158
/**
159159
* push to github
160160
*/
161-
if (commitAndPush) {
161+
if (shouldCommitAndPush) {
162162
await commitAndPush(versions);
163163
}
164164
}

0 commit comments

Comments
 (0)