Skip to content

Commit 9a50c1e

Browse files
committed
adjust util test
1 parent 8118019 commit 9a50c1e

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

config/karma.base.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ const path = require('path');
2020
const webpackTestConfig = require('./webpack.test');
2121
const { argv } = require('yargs');
2222

23-
// FIXME: trigger all tests
24-
2523
function determineBrowsers() {
2624
const supportedBrowsers = ['ChromeHeadless', 'WebkitHeadless', 'Firefox'];
2725

packages/util/test/errors.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,8 @@ describe('FirebaseError', () => {
8989
throw e;
9090
} catch (error) {
9191
assert.isDefined((error as Error).stack);
92-
// Multi-line match trick - .* does not match \n
93-
console.log('** Error stack **');
94-
console.log((error as Error).stack);
95-
assert.match((error as Error).stack!, /FirebaseError[\s\S]/);
92+
// Firefox no longer puts the error class name in the stack
93+
// as of 139.0 so we don't have a string to match on.
9694
}
9795
});
9896

scripts/run_tests_in_ci.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ const argv = yargs.options({
6767
try {
6868
if (process.env?.BROWSERS) {
6969
if (scripts['test:browser']) {
70-
scriptName = 'test:browser';
70+
scriptName = 'test:browser';
7171
}
7272
for (const package in crossBrowserPackages) {
7373
if (dir.endsWith(package)) {
@@ -80,7 +80,9 @@ const argv = yargs.options({
8080
}
8181

8282
console.log(
83-
`[${name}][${process.env.BROWSERS ?? 'chrome/node'}]: Running script ${scriptName}`
83+
`[${name}][${
84+
process.env.BROWSERS ?? 'chrome/node'
85+
}]: Running script ${scriptName}`
8486
);
8587

8688
const testProcess = spawn('yarn', ['--cwd', dir, scriptName]);

0 commit comments

Comments
 (0)