Skip to content

Commit 9b65f10

Browse files
committed
Removing and renaming tests based on PR feedback.
1 parent fdb81ad commit 9b65f10

File tree

1 file changed

+2
-59
lines changed

1 file changed

+2
-59
lines changed

packages/firestore/test/integration/api/query.test.ts

Lines changed: 2 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -1458,7 +1458,7 @@ apiDescribe('Queries', (persistence: boolean) => {
14581458
});
14591459
});
14601460

1461-
it('can use or queries with in and not-in', () => {
1461+
it('can use or queries with in', () => {
14621462
const testDocs = {
14631463
doc1: { a: 1, b: 0 },
14641464
doc2: { b: 1 },
@@ -1531,69 +1531,12 @@ apiDescribe('Queries', (persistence: boolean) => {
15311531
'doc6'
15321532
);
15331533

1534-
// Two IN operations on different fields with conjunction.
1535-
await checkOnlineAndOfflineResultsMatch(
1536-
query(coll, and(where('a', 'in', [2, 3]), where('b', 'in', [0, 2]))),
1537-
'doc3'
1538-
);
1539-
1540-
// Two IN operations on the same field.
1541-
// a IN [1,2,3] && a IN [0,1,4] should result in "a==1".
1542-
await checkOnlineAndOfflineResultsMatch(
1543-
query(
1544-
coll,
1545-
and(where('a', 'in', [1, 2, 3]), where('a', 'in', [0, 1, 4]))
1546-
),
1547-
'doc1',
1548-
'doc4',
1549-
'doc5'
1550-
);
1551-
1552-
// a IN [2,3] && a IN [0,1,4] is never true and so the result should be an
1553-
// empty set.
1554-
await checkOnlineAndOfflineResultsMatch(
1555-
query(
1556-
coll,
1557-
and(where('a', 'in', [2, 3]), where('a', 'in', [0, 1, 4]))
1558-
)
1559-
);
1560-
15611534
// a IN [0,3] || a IN [0,2] should union them (similar to: a IN [0,2,3]).
15621535
await checkOnlineAndOfflineResultsMatch(
15631536
query(coll, or(where('a', 'in', [0, 3]), where('a', 'in', [0, 2]))),
15641537
'doc3',
15651538
'doc6'
15661539
);
1567-
1568-
// Nested composite filter on the same field.
1569-
await checkOnlineAndOfflineResultsMatch(
1570-
query(
1571-
coll,
1572-
and(
1573-
where('a', 'in', [1, 3]),
1574-
or(
1575-
where('a', 'in', [0, 2]),
1576-
and(where('b', '==', 2), where('a', 'in', [1, 3]))
1577-
)
1578-
)
1579-
),
1580-
'doc3'
1581-
);
1582-
1583-
// Nested composite filter on the different fields.
1584-
await checkOnlineAndOfflineResultsMatch(
1585-
query(
1586-
coll,
1587-
and(
1588-
where('b', 'in', [0, 3]),
1589-
or(
1590-
where('b', 'in', [1]),
1591-
and(where('b', 'in', [2, 3]), where('a', 'in', [1, 3]))
1592-
)
1593-
)
1594-
),
1595-
'doc4'
1596-
);
15971540
});
15981541
});
15991542

@@ -1806,7 +1749,7 @@ apiDescribe('Queries', (persistence: boolean) => {
18061749
});
18071750
});
18081751

1809-
it('can use or queries with in and not-in', () => {
1752+
it('can use or queries with not-in', () => {
18101753
const testDocs = {
18111754
doc1: { a: 1, b: 0 },
18121755
doc2: { b: 1 },

0 commit comments

Comments
 (0)