Skip to content

Commit 9c22251

Browse files
authored
Remove backgroundChannelTest and testUrl from WebChannelOptions (#2666)
These will be deprecated in an upcoming google-closure-library release Note: backgroundChannelTest already defaults to true and we don't use testUrl.
1 parent 051e3c3 commit 9c22251

File tree

3 files changed

+0
-11
lines changed

3 files changed

+0
-11
lines changed

packages/firestore/src/platform_browser/webchannel_connection.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -228,11 +228,6 @@ export class WebChannelConnection implements Connection {
228228
];
229229
const webchannelTransport = createWebChannelTransport();
230230
const request: WebChannelOptions = {
231-
// Background channel test avoids the initial two test calls and decreases
232-
// initial cold start time.
233-
// TODO(dimond): wenboz@ mentioned this might affect use with proxies and
234-
// we should monitor closely for any reports.
235-
backgroundChannelTest: true,
236231
// Required for backend stickiness, routing behavior is based on this
237232
// parameter.
238233
httpSessionIdParam: 'gsessionid',

packages/webchannel-wrapper/externs/overrides.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ goog.net.WebChannel.Options.concurrentRequestLimit;
4545
/** @type {boolean|undefined} */
4646
goog.net.WebChannel.Options.supportsCrossDomainXhr;
4747

48-
/** @type {string|undefined} */
49-
goog.net.WebChannel.Options.testUrl;
50-
5148
/** @type {boolean|undefined} */
5249
goog.net.WebChannel.Options.sendRawJson;
5350

@@ -57,7 +54,6 @@ goog.net.WebChannel.Options.httpSessionIdParam;
5754
/** @type {string|undefined} */
5855
goog.net.WebChannel.Options.httpHeadersOverwriteParam;
5956

60-
/** @type {boolean|undefined} */
6157
goog.net.WebChannel.Options.backgroundChannelTest;
6258

6359
/** @type {boolean|undefined} */

packages/webchannel-wrapper/src/index.d.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,9 @@ export interface WebChannelOptions {
8585
clientProtocolHeaderRequired?: boolean;
8686
concurrentRequestLimit?: number;
8787
supportsCrossDomainXhr?: boolean;
88-
testUrl?: string;
8988
sendRawJson?: boolean;
9089
httpSessionIdParam?: string;
9190
httpHeadersOverwriteParam?: string;
92-
backgroundChannelTest?: boolean;
9391
forceLongPolling?: boolean;
9492
fastHandshake?: boolean;
9593
disableRedac?: boolean;

0 commit comments

Comments
 (0)