Skip to content

Commit 9c409ea

Browse files
Allow undefined callbacks in Storage Observer (#3224)
1 parent 308f020 commit 9c409ea

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

.changeset/popular-cups-melt.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"firebase": patch
3+
"@firebase/storage-types": patch
4+
"@firebase/storage": patch
5+
---
6+
7+
[fix] Updated the TypeScript types for all APIs using Observers to allow callback omission.

packages/firebase/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7579,7 +7579,7 @@ declare namespace firebase.storage {
75797579
on(
75807580
event: firebase.storage.TaskEvent,
75817581
nextOrObserver?:
7582-
| firebase.Observer<UploadTaskSnapshot>
7582+
| Partial<firebase.Observer<UploadTaskSnapshot>>
75837583
| null
75847584
| ((a: UploadTaskSnapshot) => any),
75857585
error?: ((a: Error) => any) | null,

packages/storage-types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export interface UploadTask {
9191
on(
9292
event: TaskEvent,
9393
nextOrObserver?:
94-
| Observer<UploadTaskSnapshot>
94+
| Partial<Observer<UploadTaskSnapshot>>
9595
| null
9696
| ((a: UploadTaskSnapshot) => any),
9797
error?: ((a: Error) => any) | null,

0 commit comments

Comments
 (0)