Update the condition in RC service of performance to allow config objects with no entries (#1747)

Author: alikn

packages/performance/src/services/remote_config_service.test.ts

@@ -176,5 +176,21 @@ describe('Performance Monitoring > remote_config_service', () => {
 
       expect(SettingsService.getInstance().loggingEnabled).to.be.true;
     });
+
+    it('uses secondary configs if the response does not have any fields', async () => {
+      // Expired local config.
+      const EXPIRY_LOCAL_STORAGE_VALUE = '1556524895320';
+      storageGetItemStub.callsFake(
+        storageGetItemFakeFactory(
+          EXPIRY_LOCAL_STORAGE_VALUE,
+          'not a valid config and should not be used'
+        )
+      );
+      const STRINGIFIED_PARTIAL_CONFIG = '{"state":"NO TEMPLATE"}';
+      fetchStub.resolves(new Response(STRINGIFIED_PARTIAL_CONFIG));
+      await getConfig(IID);
+
+      expect(SettingsService.getInstance().loggingEnabled).to.be.true;
+    });
   });
 });

packages/performance/src/services/remote_config_service.ts

@@ -147,9 +147,9 @@ function getRemoteConfig(
 function processConfig(
   config: RemoteConfigResponse | undefined
 ): RemoteConfigResponse | undefined {
-  if (!config || !config.entries) return config;
+  if (!config) return config;
   const settingsServiceInstance = SettingsService.getInstance();
-  const entries = config.entries;
+  const entries = config.entries || {};
   if (entries.fpr_enabled !== undefined) {
     // TODO: Change the assignment of loggingEnabled once the received type is known.
     settingsServiceInstance.loggingEnabled =