Rename 'chrome-extension' to 'web-extension

NhienLam · NhienLam · commit 9fcd5d82d942 · 2024-01-09T13:35:10.000-08:00
diff --git a/packages/auth/chrome-extension/package.json b/packages/auth/chrome-extension/package.json
diff --git a/packages/auth/index.web-extension.ts b/packages/auth/index.web-extension.ts
@@ -58,7 +58,7 @@ function getAuth(app: FirebaseApp = getApp()): Auth {
   return auth;
 }
 
-registerAuth(ClientPlatform.CHROME_EXTENSION);
+registerAuth(ClientPlatform.WEB_EXTENSION);
 
 export {
   indexedDBLocalPersistence,
diff --git a/packages/auth/package.json b/packages/auth/package.json
@@ -8,7 +8,7 @@
   "browser": "dist/esm2017/index.js",
   "module": "dist/esm2017/index.js",
   "cordova": "dist/cordova/index.js",
-  "chrome-extension": "dist/chrome-extension-esm2017/index.js",
+  "web-extension": "dist/web-extension-esm2017/index.js",
   "webworker": "dist/index.webworker.esm5.js",
   "esm5": "dist/esm5/index.js",
   "exports": {
@@ -42,11 +42,11 @@
       "types": "./dist/cordova/index.cordova.d.ts",
       "default": "./dist/cordova/index.js"
     },
-    "./chrome-extension": {
-      "types:": "./dist/chrome-extension-esm2017/index.chrome-extension.d.ts",
-      "import": "./dist/chrome-extension-esm2017/index.js",
-      "require": "./dist/chrome-extension-cjs/index.js",
-      "default": "./dist/chrome-extension-esm2017/index.js"
+    "./web-extension": {
+      "types:": "./dist/web-extension-esm2017/index.web-extension.d.ts",
+      "import": "./dist/web-extension-esm2017/index.js",
+      "require": "./dist/web-extension-cjs/index.js",
+      "default": "./dist/web-extension-esm2017/index.js"
     },
     "./internal": {
       "types": "./dist/internal/index.d.ts",
@@ -68,11 +68,11 @@
         "require": "./dist/browser-cjs/internal.js",
         "import": "./dist/esm2017/internal.js"
       },
-      "chrome-extension": {
-        "types:": "./dist/chrome-extension-cjs/internal/index.d.ts",
-        "import": "./dist/chrome-extension-esm2017/internal.js",
-        "require": "./dist/chrome-extension-cjs/internal.js",
-        "default": "./dist/chrome-extension-esm2017/internal.js"
+      "web-extension": {
+        "types:": "./dist/web-extension-cjs/internal/index.d.ts",
+        "import": "./dist/web-extension-esm2017/internal.js",
+        "require": "./dist/web-extension-cjs/internal.js",
+        "default": "./dist/web-extension-esm2017/internal.js"
       },
       "default": "./dist/esm2017/internal.js"
     },
@@ -82,7 +82,7 @@
     "dist",
     "cordova/package.json",
     "internal/package.json",
-    "chrome-extension/package.json"
+    "web-extension/package.json"
   ],
   "scripts": {
     "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
diff --git a/packages/auth/rollup.config.js b/packages/auth/rollup.config.js
@@ -112,14 +112,14 @@ const browserBuilds = [
   }
 ];
 
-const browserChromeExtensionBuilds = [
+const browserWebExtensionBuilds = [
   {
     input: {
-      index: 'index.chrome-extension.ts',
+      index: 'index.web-extension.ts',
       internal: 'internal/index.ts'
     },
     output: {
-      dir: 'dist/chrome-extension-esm2017',
+      dir: 'dist/web-extension-esm2017',
       format: 'es',
       sourcemap: true
     },
@@ -131,12 +131,10 @@ const browserChromeExtensionBuilds = [
   },
   {
     input: {
-      index: 'index.chrome-extension.ts',
+      index: 'index.web-extension.ts',
       internal: 'internal/index.ts'
     },
-    output: [
-      { dir: 'dist/chrome-extension-cjs', format: 'cjs', sourcemap: true }
-    ],
+    output: [{ dir: 'dist/web-extension-cjs', format: 'cjs', sourcemap: true }],
     plugins: [
       ...es2017BuildPlugins,
       replace(generateBuildTargetReplaceConfig('cjs', 2017))
@@ -231,7 +229,7 @@ const webWorkerBuild = {
 
 export default [
   ...browserBuilds,
-  ...browserChromeExtensionBuilds,
+  ...browserWebExtensionBuilds,
   ...nodeBuilds,
   cordovaBuild,
   rnBuild,
diff --git a/packages/auth/src/core/auth/register.ts b/packages/auth/src/core/auth/register.ts
@@ -49,8 +49,8 @@ function getVersionForPlatform(
       return 'webworker';
     case ClientPlatform.CORDOVA:
       return 'cordova';
-    case ClientPlatform.CHROME_EXTENSION:
-      return 'chrome-extension';
+    case ClientPlatform.WEB_EXTENSION:
+      return 'web-extension';
     default:
       return undefined;
   }
diff --git a/packages/auth/src/core/util/version.test.ts b/packages/auth/src/core/util/version.test.ts
@@ -57,10 +57,10 @@ describe('core/util/_getClientVersion', () => {
       });
     });
 
-    context('Chrome Extension', () => {
+    context('Web Extension', () => {
       it('should set the correct version', () => {
-        expect(_getClientVersion(ClientPlatform.CHROME_EXTENSION)).to.eq(
-          `ChromeExtension/JsCore/${SDK_VERSION}/FirebaseCore-web`
+        expect(_getClientVersion(ClientPlatform.WEB_EXTENSION)).to.eq(
+          `WebExtension/JsCore/${SDK_VERSION}/FirebaseCore-web`
         );
       });
     });
diff --git a/packages/auth/src/core/util/version.ts b/packages/auth/src/core/util/version.ts
@@ -32,7 +32,7 @@ export const enum ClientPlatform {
   REACT_NATIVE = 'ReactNative',
   CORDOVA = 'Cordova',
   WORKER = 'Worker',
-  CHROME_EXTENSION = 'ChromeExtension'
+  WEB_EXTENSION = 'WebExtension'
 }
 
 /*
diff --git a/packages/auth/web-extension/package.json b/packages/auth/web-extension/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@firebase/auth/web-extension",
+  "description": "A Chrome-Manifest-v3-specific build of the Firebase Auth JS SDK",
+  "main": "../dist/web-extension-cjs/index.js",
+  "browser": "../dist/web-extension-esm2017/index.js",
+  "module": "../dist/web-extension-esm2017/index.js",
+  "typings": "../dist/web-extension-esm2017/index.web-extension.d.ts"
+}
diff --git a/packages/firebase/auth/web-extension/index.ts b/packages/firebase/auth/web-extension/index.ts
@@ -15,4 +15,4 @@
  * limitations under the License.
  */
 
-export * from '@firebase/auth/chrome-extension';
+export * from '@firebase/auth/web-extension';
diff --git a/packages/firebase/auth/web-extension/package.json b/packages/firebase/auth/web-extension/package.json
@@ -1,7 +1,7 @@
 {
-  "name": "firebase/auth/chrome-extension",
+  "name": "firebase/auth/web-extension",
   "main": "dist/index.cjs.js",
   "browser": "dist/esm/index.esm.js",
   "module": "dist/esm/index.esm.js",
-  "typings": "dist/auth/chrome-extension/index.d.ts"
+  "typings": "dist/auth/web-extension/index.d.ts"
 }
diff --git a/packages/firebase/package.json b/packages/firebase/package.json
@@ -83,17 +83,17 @@
       },
       "default": "./auth/cordova/dist/esm/index.esm.js"
     },
-    "./auth/chrome-extension": {
-      "types": "./auth/chrome-extension/dist/auth/chrome-extension/index.d.ts",
+    "./auth/web-extension": {
+      "types": "./auth/web-extension/dist/auth/web-extension/index.d.ts",
       "node": {
-        "require": "./auth/chrome-extension/dist/index.cjs.js",
-        "import": "./auth/chrome-extension/dist/index.mjs"
+        "require": "./auth/web-extension/dist/index.cjs.js",
+        "import": "./auth/web-extension/dist/index.mjs"
       },
       "browser": {
-        "require": "./auth/chrome-extension/dist/index.cjs.js",
-        "import": "./auth/chrome-extension/dist/esm/index.esm.js"
+        "require": "./auth/web-extension/dist/index.cjs.js",
+        "import": "./auth/web-extension/dist/esm/index.esm.js"
       },
-      "default": "./auth/chrome-extension/dist/esm/index.esm.js"
+      "default": "./auth/web-extension/dist/esm/index.esm.js"
     },
     "./database": {
       "types": "./database/dist/database/index.d.ts",
@@ -421,7 +421,7 @@
     "app-check",
     "auth",
     "auth/cordova",
-    "auth/chrome-extension",
+    "auth/web-extension",
     "functions",
     "firestore",
     "firestore/lite",

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ function getAuth(app: FirebaseApp = getApp()): Auth {`
`58`	`58`	`return auth;`
`59`	`59`	`}`
`60`	`60`
`61`		`-registerAuth(ClientPlatform.CHROME_EXTENSION);`
	`61`	`+registerAuth(ClientPlatform.WEB_EXTENSION);`
`62`	`62`
`63`	`63`	`export {`
`64`	`64`	`indexedDBLocalPersistence,`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ export const enum ClientPlatform {`
`32`	`32`	`REACT_NATIVE = 'ReactNative',`
`33`	`33`	`CORDOVA = 'Cordova',`
`34`	`34`	`WORKER = 'Worker',`
`35`		`- CHROME_EXTENSION = 'ChromeExtension'`
	`35`	`+ WEB_EXTENSION = 'WebExtension'`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`/*`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`		`- "name": "firebase/auth/chrome-extension",`
	`2`	`+ "name": "firebase/auth/web-extension",`
`3`	`3`	`"main": "dist/index.cjs.js",`
`4`	`4`	`"browser": "dist/esm/index.esm.js",`
`5`	`5`	`"module": "dist/esm/index.esm.js",`
`6`		`- "typings": "dist/auth/chrome-extension/index.d.ts"`
	`6`	`+ "typings": "dist/auth/web-extension/index.d.ts"`
`7`	`7`	`}`