Replace FIXMEs with TODOs

dlarocque · dlarocque · commit a073d36dff7f · 2024-07-15T10:42:27.000-04:00
diff --git a/packages/auth/src/platform_browser/index.ts b/packages/auth/src/platform_browser/index.ts
@@ -124,7 +124,7 @@ _setExternalJSProvider({
     // TODO: consider adding timeout support & cancellation
     return new Promise((resolve, reject) => {
       const el = document.createElement('script');
-      // FIXME: Do not use setAttribute, since it can lead to XSS. Instead, use the safevalues library to
+      // TODO: Do not use setAttribute, since it can lead to XSS. Instead, use the safevalues library to
       // safely set an attribute for a sanitized trustedResourceUrl. Since the trustedResourceUrl
       // must be initialized from a template string literal, this could involve some heavy
       // refactoring.
diff --git a/packages/auth/src/platform_browser/load_js.test.ts b/packages/auth/src/platform_browser/load_js.test.ts
@@ -44,7 +44,7 @@ describe('platform-browser/load_js', () => {
         loadJS(url: string): Promise<Event> {
           return new Promise((resolve, reject) => {
             const el = document.createElement('script');
-            // FIXME: Do not use setAttribute, as this can lead to XSS. Instead, use the safevalues
+            // TODO: Do not use setAttribute, as this can lead to XSS. Instead, use the safevalues
             // library, or get an exception for tests.
             el.setAttribute('src', url);
             el.onload = resolve;
@@ -67,7 +67,7 @@ describe('platform-browser/load_js', () => {
 
       // eslint-disable-next-line @typescript-eslint/no-floating-promises
       _loadJS('http://localhost/url');
-      // FIXME: Do not use setAttribute, as this can lead to XSS. Instead, use the safevalues
+      // TODO: Do not use setAttribute, as this can lead to XSS. Instead, use the safevalues
       // library, or get an exception for tests.
       expect(el.setAttribute).to.have.been.calledWith(
         'src',
diff --git a/packages/database/src/realtime/BrowserPollConnection.ts b/packages/database/src/realtime/BrowserPollConnection.ts
@@ -475,7 +475,7 @@ export class FirebaseIFrameScriptHolder {
       const iframeContents = '<html><body>' + script + '</body></html>';
       try {
         this.myIFrame.doc.open();
-        // FIXME: Do not use document.write, since it can lead to XSS. Instead, use the safevalues
+        // TODO: Do not use document.write, since it can lead to XSS. Instead, use the safevalues
         // library to sanitize the HTML in the iframeContents.
         this.myIFrame.doc.write(iframeContents);
         this.myIFrame.doc.close();
@@ -719,7 +719,7 @@ export class FirebaseIFrameScriptHolder {
           const newScript = this.myIFrame.doc.createElement('script');
           newScript.type = 'text/javascript';
           newScript.async = true;
-          // FIXME: We cannot assign an arbitrary URL to a script attached to the DOM, since it is
+          // TODO: We cannot assign an arbitrary URL to a script attached to the DOM, since it is
           // at risk of XSS. We should use the safevalues library to create a safeScriptEl, and
           // assign a sanitized trustedResourceURL to it. Since the URL must be a template string
           // literal, this could require some heavy refactoring.
diff --git a/packages/messaging/src/helpers/registerDefaultSw.ts b/packages/messaging/src/helpers/registerDefaultSw.ts
@@ -24,7 +24,7 @@ export async function registerDefaultSw(
   messaging: MessagingService
 ): Promise<void> {
   try {
-    // FIXME: Use safevalues to register the service worker with a sanitized trustedResourceUrl.
+    // TODO: Use safevalues to register the service worker with a sanitized trustedResourceUrl.
     messaging.swRegistration = await navigator.serviceWorker.register(
       DEFAULT_SW_PATH,
       {

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ export async function registerDefaultSw(`
`24`	`24`	`messaging: MessagingService`
`25`	`25`	`): Promise<void> {`
`26`	`26`	`try {`
`27`		`- // FIXME: Use safevalues to register the service worker with a sanitized trustedResourceUrl.`
	`27`	`+ // TODO: Use safevalues to register the service worker with a sanitized trustedResourceUrl.`
`28`	`28`	`messaging.swRegistration = await navigator.serviceWorker.register(`
`29`	`29`	`DEFAULT_SW_PATH,`
`30`	`30`	`{`