Skip to content

Commit a124493

Browse files
www
1 parent dc384d6 commit a124493

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

packages/firestore/src/core/component_provider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ import {
4444
} from '../local/memory_persistence';
4545

4646
const MEMORY_ONLY_PERSISTENCE_ERROR_MESSAGE =
47-
'You are using the memory-only build of Firestore. Persistence support is ' +
47+
'You ARE using the memory-only build of Firestore. Persistence support is ' +
4848
'only available via the @firebase/firestore bundle or the ' +
4949
'firebase-firestore.js build.';
5050

scripts/run_changed.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,18 @@ async function getChangedPackages() {
9696
return { testAll: true };
9797
}
9898
// Files outside a package dir that should trigger its tests.
99+
console.log(filename);
99100
const matchingSpecialPaths = Object.keys(specialPaths).filter(path =>
100101
filename.startsWith(path)
101102
);
102-
for (const targetPackage of specialPaths[matchingSpecialPaths]) {
103-
changedPackages[targetPackage] = 'dependency';
103+
console.log(matchingSpecialPaths);
104+
for (const matchingSpecialPath of matchingSpecialPaths) {
105+
for (const targetPackage of specialPaths[matchingSpecialPath]) {
106+
changedPackages[targetPackage] = 'dependency';
107+
}
104108
}
109+
console.log(changedPackages);
110+
throw new Error('foo');
105111
// Check for changed files inside package dirs.
106112
const match = filename.match('^(packages(-exp)?/[a-zA-Z0-9-]+)/.*');
107113
if (match && match[1]) {

0 commit comments

Comments
 (0)