Skip to content

Commit a78043f

Browse files
committed
use v8 version by default
1 parent 4ac6a79 commit a78043f

File tree

8 files changed

+2
-23
lines changed

8 files changed

+2
-23
lines changed

packages/firestore/index.console.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,8 @@ import {
2323
MemoryPersistenceProvider
2424
} from './src/api/database';
2525
import { DatabaseId } from './src/core/database_info';
26-
import { setSDKVersion } from './src/core/version';
2726
import { FirebaseFirestore as FirestoreExp } from './src/exp/database';
2827
import { Code, FirestoreError } from './src/util/error';
29-
import { version as SDK_VERSION } from '../firebase/package.json';
3028
export {
3129
CollectionReference,
3230
DocumentReference,
@@ -73,5 +71,3 @@ function databaseIdFromFirestoreDatabase(
7371
firestoreDatabase.database
7472
);
7573
}
76-
77-
setSDKVersion(SDK_VERSION);

packages/firestore/index.memory.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import firebase from '@firebase/app';
1919
import { FirebaseNamespace } from '@firebase/app-types';
2020

21-
import { version as SDK_VERSION } from '../firebase/package.json';
2221
import {
2322
Firestore,
2423
MemoryPersistenceProvider,
@@ -28,13 +27,11 @@ import { name, version } from './package.json';
2827
import { configureForFirebase } from './src/config';
2928

3029
import './register-module';
31-
import { setSDKVersion } from './src/core/version';
3230

3331
/**
3432
* Registers the memory-only Firestore build with the components framework.
3533
*/
3634
export function registerFirestore(instance: FirebaseNamespace): void {
37-
setSDKVersion(SDK_VERSION);
3835
configureForFirebase(
3936
instance,
4037
(app, auth) =>

packages/firestore/index.node.memory.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,18 @@
1818
import firebase from '@firebase/app';
1919
import { FirebaseNamespace } from '@firebase/app-types';
2020

21-
import { version as SDK_VERSION } from '../firebase/package.json';
2221
import { name, version } from './package.json';
2322
import { Firestore, MemoryPersistenceProvider } from './src/api/database';
2423
import { configureForFirebase } from './src/config';
2524
import { FirebaseFirestore } from './src/exp/database';
2625

2726
import './register-module';
28-
import { setSDKVersion } from './src/core/version';
2927

3028
/**
3129
* Registers the memory-only Firestore build for Node with the components
3230
* framework.
3331
*/
3432
export function registerFirestore(instance: FirebaseNamespace): void {
35-
setSDKVersion(SDK_VERSION);
3633
configureForFirebase(
3734
instance,
3835
(app, auth) =>

packages/firestore/index.node.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,18 @@
1717
import firebase from '@firebase/app';
1818
import { FirebaseNamespace } from '@firebase/app-types';
1919

20-
import { version as SDK_VERSION } from '../firebase/package.json';
2120
import { name, version } from './package.json';
2221
import { Firestore, IndexedDbPersistenceProvider } from './src/api/database';
2322
import { configureForFirebase } from './src/config';
2423
import { FirebaseFirestore as ExpFirebaseFirestore } from './src/exp/database';
2524

2625
import './register-module';
27-
import { setSDKVersion } from './src/core/version';
2826

2927
/**
3028
* Registers the main Firestore Node build with the components framework.
3129
* Persistence can be enabled via `firebase.firestore().enablePersistence()`.
3230
*/
3331
export function registerFirestore(instance: FirebaseNamespace): void {
34-
setSDKVersion(SDK_VERSION);
3532
configureForFirebase(
3633
instance,
3734
(app, auth) =>

packages/firestore/index.rn.memory.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,14 @@ import {
2525
} from './export';
2626
import { name, version } from './package.json';
2727
import { configureForFirebase } from './src/config';
28-
import { version as SDK_VERSION } from '../firebase/package.json';
2928

3029
import './register-module';
31-
import { setSDKVersion } from './src/core/version';
3230

3331
/**
3432
* Registers the memory-only Firestore build for ReactNative with the components
3533
* framework.
3634
*/
3735
export function registerFirestore(instance: FirebaseNamespace): void {
38-
setSDKVersion(SDK_VERSION);
3936
configureForFirebase(
4037
instance,
4138
(app, auth) =>

packages/firestore/index.rn.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,14 @@ import {
2424
} from './export';
2525
import { name, version } from './package.json';
2626
import { configureForFirebase } from './src/config';
27-
import { version as SDK_VERSION } from '../firebase/package.json';
2827

2928
import './register-module';
30-
import { setSDKVersion } from './src/core/version';
3129

3230
/**
3331
* Registers the main Firestore ReactNative build with the components framework.
3432
* Persistence can be enabled via `firebase.firestore().enablePersistence()`.
3533
*/
3634
export function registerFirestore(instance: FirebaseNamespace): void {
37-
setSDKVersion(SDK_VERSION);
3835
configureForFirebase(
3936
instance,
4037
(app, auth) =>

packages/firestore/index.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,14 @@ import {
2525
} from './export';
2626
import { name, version } from './package.json';
2727
import { configureForFirebase } from './src/config';
28-
import { version as SDK_VERSION } from '../firebase/package.json';
2928

3029
import './register-module';
31-
import { setSDKVersion } from './src/core/version';
3230

3331
/**
3432
* Registers the main Firestore build with the components framework.
3533
* Persistence can be enabled via `firebase.firestore().enablePersistence()`.
3634
*/
3735
export function registerFirestore(instance: FirebaseNamespace): void {
38-
setSDKVersion(SDK_VERSION);
3936
configureForFirebase(
4037
instance,
4138
(app, auth) =>

packages/firestore/src/core/version.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
*/
1717

1818
/** The semver (www.semver.org) version of the SDK. */
19-
export let SDK_VERSION = '';
19+
import { version } from '../../../firebase/package.json';
20+
export let SDK_VERSION = version;
2021
export function setSDKVersion(version: string): void {
2122
SDK_VERSION = version;
2223
}

0 commit comments

Comments
 (0)