Skip to content

Commit a81fbb7

Browse files
fix(*): Fix compilation problems in my local environment
1 parent bcd13ad commit a81fbb7

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/messaging/controllers/window-controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export default class WindowController extends ControllerInterface {
247247
const serviceWorker = registration.installing || registration.waiting ||
248248
registration.active;
249249

250-
return new Promise((resolve, reject) => {
250+
return new Promise<ServiceWorkerRegistration>((resolve, reject) => {
251251
if (!serviceWorker) {
252252
// This is a rare scenario but has occured in firefox
253253
reject(this.errorFactory_.create(Errors.codes.NO_SW_IN_REG));

src/messaging/models/db-interface.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export default class DBInterface {
2525
private dbVersion_: number;
2626
private openDbPromise_: Promise<IDBDatabase>;
2727
protected errorFactory_: ErrorFactory<string>;
28-
protected TRANSACTION_READ_WRITE: string;
28+
protected TRANSACTION_READ_WRITE: IDBTransactionMode;
2929

3030
/**
3131
* @param {string} dbName

src/storage/task.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -493,13 +493,13 @@ export class UploadTask {
493493
/**
494494
* This object behaves like a Promise, and resolves with its snapshot data
495495
* when the upload completes.
496-
* The fulfillment callback. Promise chaining works as normal.
496+
* @param onFulfilled The fulfillment callback. Promise chaining works as normal.
497497
* @param onRejected The rejection callback.
498498
*/
499499
then<U>(onFulfilled?: ((value: UploadTaskSnapshot) => U | PromiseLike<U>) | null, onRejected?: ((error: any) => U | PromiseLike<U>) | null): Promise<U> {
500500
return this.promise_.then<U>(
501501
(onFulfilled as (value: UploadTaskSnapshot) => U | PromiseLike<U>),
502-
(onRejected as ((error: any) => PromiseLike<U>) | null));
502+
(onRejected as ((error: any) => PromiseLike<never>) | null));
503503
}
504504

505505
/**

0 commit comments

Comments
 (0)