enable no-console for test files

Author: Feiyang1

packages/firestore/.eslintrc.json

@@ -16,14 +16,5 @@
                 "args": "none"
             }
         ]
-    },
-    "overrides": {
-        "files": [
-            "*test.ts",
-            "**/test/**/*.ts"
-        ],
-        "rules": {
-            "no-console": "off"
-        }
     }
 }

packages/firestore/test/integration/util/helpers.ts

@@ -46,6 +46,7 @@ const PROD_FIRESTORE_SETTING = {
 
 export const DEFAULT_SETTINGS = getDefaultSettings();
 
+// eslint-disable-next-line no-console
 console.log(`Default Settings: ${JSON.stringify(DEFAULT_SETTINGS)}`);
 
 function getDefaultSettings(): firestore.Settings {

packages/firestore/test/unit/local/simple_db.test.ts

@@ -511,7 +511,7 @@ describe('SimpleDb', () => {
       }
       return PersistencePromise.waitFor(promises).next(() => {
         const end = new Date().getTime();
-        // tslint:disable-next-line:no-console
+        // eslint-disable-next-line no-console
         console.log(`Writing: ${end - start} ms`);
       });
     }).then(() => {
@@ -523,7 +523,7 @@ describe('SimpleDb', () => {
         }
         return PersistencePromise.waitFor(promises).next(() => {
           const end = new Date().getTime();
-          // tslint:disable-next-line:no-console
+          // eslint-disable-next-line no-console
           console.log(`Reading: ${end - start} ms`);
         });
       });

packages/firestore/test/unit/specs/describe_spec.ts

@@ -176,6 +176,7 @@ export function specTest(
         await spec.runAsTest(fullName, usePersistence);
         const end = Date.now();
         if (tags.indexOf(BENCHMARK_TAG) >= 0) {
+          // eslint-disable-next-line no-console
           console.log(`Runtime: ${end - start} ms.`);
         }
       });

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -1240,6 +1240,7 @@ export async function runSpec(
   config: SpecConfig,
   steps: SpecStep[]
 ): Promise<void> {
+  // eslint-disable-next-line no-console
   console.log('Running spec: ' + name);
 
   const sharedMockStorage = new SharedFakeWebStorage();

packages/firestore/test/unit/util/sorted_map.test.ts

@@ -301,7 +301,7 @@ describe('SortedMap Tests', () => {
         map = map.remove(i);
       }
       const end = new Date().getTime();
-      // tslint:disable-next-line:no-console
+      // eslint-disable-next-line no-console
       console.log(end - start);
     }
   });
@@ -348,7 +348,7 @@ describe('SortedMap Tests', () => {
       }
 
       const elapsed = new Date().getTime() - start.getTime();
-      // tslint:disable-next-line:no-console
+      // eslint-disable-next-line no-console
       console.log(N + ': ' + elapsed);
     }
   });
@@ -395,7 +395,7 @@ describe('SortedMap Tests', () => {
       }
 
       const elapsed = new Date().getTime() - start.getTime();
-      // tslint:disable-next-line:no-console
+      // eslint-disable-next-line no-console
       console.log(N + ': ' + elapsed);
     }
   });