Revert change to public policy type and policy response

Author: ch5zzy

docs-devsite/auth.passwordpolicy.md

@@ -32,7 +32,7 @@ List of characters that are considered non-alphanumeric during validation.
 <b>Signature:</b>
 
 ```typescript
-readonly allowedNonAlphanumericCharacters?: string[];
+readonly allowedNonAlphanumericCharacters: string[];
 ```
 
 ## PasswordPolicy.customStrengthOptions

packages/auth/src/api/password_policy/get_password_policy.ts

@@ -42,7 +42,7 @@ export interface GetPasswordPolicyResponse {
     containsNumericCharacter?: boolean;
     containsNonAlphanumericCharacter?: boolean;
   };
-  allowedNonAlphanumericCharacters?: string[];
+  allowedNonAlphanumericCharacters: string[];
   schemaVersion: number;
 }
 

packages/auth/src/core/auth/password_policy_impl.test.ts

@@ -51,6 +51,7 @@ describe('core/auth/password_policy_impl', () => {
       minPasswordLength: TEST_MIN_PASSWORD_LENGTH,
       maxPasswordLength: TEST_MAX_PASSWORD_LENGTH
     },
+    allowedNonAlphanumericCharacters: TEST_ALLOWED_NON_ALPHANUMERIC_CHARS,
     schemaVersion: TEST_SCHEMA_VERSION
   };
   const passwordPolicyRequireAll: PasswordPolicy = {
@@ -68,7 +69,8 @@ describe('core/auth/password_policy_impl', () => {
     customStrengthOptions: {
       minPasswordLength: TEST_MIN_PASSWORD_LENGTH,
       maxPasswordLength: TEST_MAX_PASSWORD_LENGTH
-    }
+    },
+    allowedNonAlphanumericCharacters: TEST_ALLOWED_NON_ALPHANUMERIC_CHARS
   };
 
   context('#PasswordPolicyImpl', () => {

packages/auth/src/core/auth/password_policy_impl.ts

@@ -30,7 +30,7 @@ import { PasswordValidationStatus } from '../../model/public_types';
  */
 export class PasswordPolicyImpl implements PasswordPolicyInternal {
   readonly customStrengthOptions: PasswordPolicyCustomStrengthOptions;
-  readonly allowedNonAlphanumericCharacters?: string[];
+  readonly allowedNonAlphanumericCharacters: string[];
   readonly schemaVersion: number;
 
   constructor(response: GetPasswordPolicyResponse) {
@@ -62,10 +62,8 @@ export class PasswordPolicyImpl implements PasswordPolicyInternal {
         responseOptions.containsNonAlphanumericCharacter;
     }
 
-    if (response.allowedNonAlphanumericCharacters) {
-      this.allowedNonAlphanumericCharacters =
-        response.allowedNonAlphanumericCharacters;
-    }
+    this.allowedNonAlphanumericCharacters =
+      response.allowedNonAlphanumericCharacters;
     this.schemaVersion = response.schemaVersion;
   }
 
@@ -75,7 +73,7 @@ export class PasswordPolicyImpl implements PasswordPolicyInternal {
       passwordPolicy: this
     };
 
-    // TODO: Implement _checkLengthOptions and _checkCharacterOptions as helper methods.
+    // TODO: Implement private helper methods for checking length and character options.
     // Call these here to populate the status object.
     if (password) {
       status.isValid = true;

packages/auth/src/model/public_types.ts

@@ -1291,7 +1291,7 @@ export interface PasswordPolicy {
   /**
    * List of characters that are considered non-alphanumeric during validation.
    */
-  readonly allowedNonAlphanumericCharacters?: string[];
+  readonly allowedNonAlphanumericCharacters: string[];
 }
 
 /**