Skip to content

Commit ab4dfb9

Browse files
Remove assert
1 parent d5e60ca commit ab4dfb9

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

packages/firestore/exp/src/api/components.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,22 +53,19 @@ export async function setOfflineComponentProvider(
5353
persistenceSettings: PersistenceSettings,
5454
offlineComponentProvider: OfflineComponentProvider
5555
): Promise<void> {
56-
debugAssert(
57-
!onlineComponentProviders.has(firestore),
58-
'The offline component provider must be registered before the online ' +
59-
'component provider.'
60-
);
61-
const configuration = await firestore._getConfiguration();
62-
configuration.persistenceSettings = persistenceSettings;
63-
6456
const offlineDeferred = new Deferred<OfflineComponentProvider>();
6557
offlineComponentProviders.set(firestore, offlineDeferred.promise);
6658

59+
const configuration = await firestore._getConfiguration();
60+
configuration.persistenceSettings = persistenceSettings;
61+
6762
logDebug(LOG_TAG, 'Initializing OfflineComponentProvider');
6863
await offlineComponentProvider.initialize(configuration);
6964
firestore._setCredentialChangeListener(user =>
7065
// TODO(firestorexp): This should be a retryable IndexedDB operation
7166
firestore._queue.enqueueAndForget(() =>
67+
// TODO(firestorexp): Make sure handleUserChange is a no-op if user
68+
// didn't change
7269
offlineComponentProvider.localStore.handleUserChange(user)
7370
)
7471
);
@@ -87,9 +84,10 @@ export async function setOnlineComponentProvider(
8784
const onlineDeferred = new Deferred<OnlineComponentProvider>();
8885
onlineComponentProviders.set(firestore, onlineDeferred.promise);
8986

90-
logDebug(LOG_TAG, 'Initializing OnlineComponentProvider');
9187
const configuration = await firestore._getConfiguration();
9288
const offlineComponentProvider = await getOfflineComponentProvider(firestore);
89+
90+
logDebug(LOG_TAG, 'Initializing OnlineComponentProvider');
9391
await onlineComponentProvider.initialize(
9492
offlineComponentProvider,
9593
configuration

0 commit comments

Comments
 (0)