Skip to content

Commit ab60f5f

Browse files
authored
Fix analytics-types-exp import and fix exp release script (#4325)
1 parent 09470fe commit ab60f5f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages-exp/analytics-exp/src/helpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
ControlParams,
2424
EventParams,
2525
MinimalDynamicConfig
26-
} from '@firebase/analytics-types';
26+
} from '@firebase/analytics-types-exp';
2727
import { GtagCommand, GTAG_URL } from './constants';
2828
import { logger } from './logger';
2929

scripts/exp/release.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ async function publishExpPackages({ dryRun }: { dryRun: boolean }) {
149149
const { shouldCommitAndPush } = await prompt([
150150
{
151151
type: 'confirm',
152-
name: 'commitAndPush',
152+
name: 'shouldCommitAndPush',
153153
message:
154154
'Do you want to commit and push the exp version update to remote?',
155155
default: true
@@ -438,7 +438,7 @@ async function updatePackageJsons(
438438
}
439439

440440
async function commitAndPush(versions: Map<string, string>) {
441-
await exec('git add */package.json yarn.lock');
441+
await exec('git add packages-exp/firebase-exp/package.json yarn.lock');
442442

443443
const firebaseExpVersion = versions.get(FIREBASE_UMBRELLA_PACKAGE_NAME);
444444
await exec(

0 commit comments

Comments
 (0)