Skip to content

Commit ac451e9

Browse files
committed
Add Safari testing for firebase and bulk
1 parent 52f713c commit ac451e9

File tree

2 files changed

+82
-0
lines changed

2 files changed

+82
-0
lines changed

.github/workflows/test-changed-firestore.yml

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,63 @@ jobs:
230230
env:
231231
BROWSERS: 'Firefox'
232232
EXPERIMENTAL_MODE: true
233+
234+
compat-test-safari:
235+
name: Test Firestore Compatible on Firefox
236+
# Whatever version of Firefox comes with 22.04 is causing Firefox
237+
# startup to hang when launched by karma. Need to look further into
238+
# why.
239+
runs-on: macos-latest
240+
needs: build
241+
if: ${{ needs.build.outputs.changed == 'true'}}
242+
steps:
243+
- name: Set up Node (20)
244+
uses: actions/setup-node@v3
245+
with:
246+
node-version: 20.x
247+
- name: Download build archive
248+
uses: actions/download-artifact@v3
249+
with:
250+
name: build.tar.gz
251+
- name: Unzip build artifact
252+
run: tar xf build.tar.gz
253+
- name: Test setup and yarn install
254+
run: cp config/ci.config.json config/project.json
255+
- name: Run compat tests
256+
run: cd packages/firestore-compat && yarn run test:ci
257+
env:
258+
BROWSERS: 'Safari'
259+
260+
test-safari:
261+
name: Test Firestore on Safari
262+
strategy:
263+
matrix:
264+
test-name: ["test:browser", "test:travis", "test:lite:browser", "test:browser:prod:nameddb", "test:lite:browser:nameddb"]
265+
# Whatever version of Firefox comes with 22.04 is causing Firefox
266+
# startup to hang when launched by karma. Need to look further into
267+
# why.
268+
runs-on: macos-latest
269+
needs: build
270+
if: ${{ needs.build.outputs.changed == 'true'}}
271+
steps:
272+
- name: Download build archive
273+
uses: actions/download-artifact@v3
274+
with:
275+
name: build.tar.gz
276+
- name: Unzip build artifact
277+
run: tar xf build.tar.gz
278+
- name: Set up Node (20)
279+
uses: actions/setup-node@v3
280+
with:
281+
node-version: 20.x
282+
- name: Test setup and yarn install
283+
run: cp config/ci.config.json config/project.json
284+
- name: Run tests
285+
run: cd packages/firestore && yarn run ${{ matrix.test-name }}
286+
env:
287+
BROWSERS: 'Safari'
288+
EXPERIMENTAL_MODE: true
289+
233290

234291
# A job that fails if any required job in the test matrix fails,
235292
# to be used as a required check for merging.

.github/workflows/test-changed.yml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,3 +78,28 @@ jobs:
7878
run: xvfb-run yarn test:changed core
7979
env:
8080
BROWSERS: 'Firefox'
81+
82+
test-safari:
83+
name: Test Packages With Changed Files in Safari
84+
runs-on: macos-latest
85+
86+
steps:
87+
- name: Checkout Repo
88+
uses: actions/checkout@v4
89+
with:
90+
fetch-depth: 0
91+
- name: Set up Node (20)
92+
uses: actions/setup-node@v3
93+
with:
94+
node-version: 20.x
95+
- name: Test setup and yarn install
96+
run: |
97+
cp config/ci.config.json config/project.json
98+
yarn
99+
- name: build
100+
run: yarn build:changed core
101+
- name: Run tests on changed packages
102+
run: yarn test:changed core
103+
env:
104+
BROWSERS: 'Safari'
105+

0 commit comments

Comments
 (0)