Skip to content

Commit ac7fee1

Browse files
authored
[E2E CI] Update firebase-tools to v13.0.2 (#7883)
Previously we ran into an issue where we couldn't use the latest firebase-tools CLI version (v13+) due to an error attempting to deploy the E2E cloud function. The error was due to a new requirement of the CLI that `firebase.json` requires a `functions` configuration. This change adds that configuration and pins the firebase CLI version to 13.0.2.
1 parent 07a65d3 commit ac7fee1

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.github/workflows/e2e-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
pushd functions
6161
npm install
6262
popd
63-
npx firebase-tools@12.9.1 deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
63+
npx firebase-tools@13.0.2 deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
6464
working-directory: ./config
6565
env:
6666
FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}

config/firebase.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,8 @@
55
"firestore": {
66
"rules": "firestore.rules",
77
"indexes": "firestore.indexes.json"
8+
},
9+
"functions": {
10+
"runtime": "nodejs18"
811
}
912
}

0 commit comments

Comments
 (0)