Rebase and update

Author: hsubox76

common/api-review/remote-config.api.md

@@ -39,6 +39,9 @@ export function getString(remoteConfig: RemoteConfig, key: string): string;
 // @public
 export function getValue(remoteConfig: RemoteConfig, key: string): Value;
 
+// @public
+export function isSupported(): Promise<boolean>;
+
 // @public
 export type LogLevel = 'debug' | 'error' | 'silent';
 

packages/firebase/compat/index.d.ts

@@ -2032,10 +2032,13 @@ declare namespace firebase.remoteConfig {
    */
   export type LogLevel = 'debug' | 'error' | 'silent';
   /**
-   * Returns true if current browser context supports
-   * initialization of a `RemoteConfig` instance (`firebase.remoteConfig()`).
+   * This method provides two different checks:
    *
-   * Returns false otherwise.
+   * 1. Check if IndexedDB exists in the browser environment.
+   * 2. Check if the current browser context allows IndexedDB `open()` calls.
+   *
+   * It returns a `Promise` which resolves to true if a {@link RemoteConfig} instance
+   * can be initialized in this environment, or false if it cannot.
    */
   export function isSupported(): Promise<boolean>;
 }
@@ -4630,13 +4633,14 @@ declare namespace firebase.auth {
    *     instance must be initialized with an API key, otherwise an error will be
    *     thrown.
    */
-  class RecaptchaVerifier extends RecaptchaVerifier_Instance { }
+  class RecaptchaVerifier extends RecaptchaVerifier_Instance {}
   /**
    * @webonly
    * @hidden
    */
   class RecaptchaVerifier_Instance
-    implements firebase.auth.ApplicationVerifier {
+    implements firebase.auth.ApplicationVerifier
+  {
     constructor(
       container: any | string,
       parameters?: Object | null,
@@ -7317,7 +7321,7 @@ declare namespace firebase.database {
 
   interface ThenableReference
     extends firebase.database.Reference,
-    Pick<Promise<Reference>, 'then' | 'catch'> { }
+      Pick<Promise<Reference>, 'then' | 'catch'> {}
 
   /**
    * Logs debugging information to the console.
@@ -7697,7 +7701,9 @@ declare namespace firebase.storage {
      *     resolves with the full updated metadata or rejects if the updated failed,
      *     including if the object did not exist.
      */
-    updateMetadata(metadata: firebase.storage.SettableMetadata): Promise<FullMetadata>;
+    updateMetadata(
+      metadata: firebase.storage.SettableMetadata
+    ): Promise<FullMetadata>;
     /**
      * List all items (files) and prefixes (folders) under this storage reference.
      *
@@ -9527,7 +9533,7 @@ declare namespace firebase.firestore {
    */
   export class QueryDocumentSnapshot<
     T = DocumentData
-    > extends DocumentSnapshot<T> {
+  > extends DocumentSnapshot<T> {
     private constructor();
 
     /**

packages/remote-config-compat/src/index.ts

@@ -22,7 +22,7 @@ import {
   ComponentType,
   InstanceFactoryOptions
 } from '@firebase/component';
-import { RemoteConfigCompatImpl } from './remoteConfig';
+import { RemoteConfigCompatImpl, isSupported } from './remoteConfig';
 import { name as packageName, version } from '../package.json';
 import { RemoteConfig as RemoteConfigCompat } from '@firebase/remote-config-types';
 
@@ -35,6 +35,7 @@ function registerRemoteConfigCompat(
       remoteConfigFactory,
       ComponentType.PUBLIC
     ).setMultipleInstances(true)
+    .setServiceProps({ isSupported })
   );
 
   firebaseInstance.registerVersion(packageName, version);

packages/remote-config-compat/src/remoteConfig.ts

@@ -34,9 +34,12 @@ import {
   getBoolean,
   getNumber,
   getString,
-  getValue
+  getValue,
+  isSupported
 } from '@firebase/remote-config';
 
+export { isSupported };
+
 export class RemoteConfigCompatImpl
   implements RemoteConfigCompat, _FirebaseService {
   constructor(public app: FirebaseApp, readonly _delegate: RemoteConfig) {}

packages/remote-config/src/api2.ts

@@ -41,12 +41,14 @@ export async function fetchAndActivate(
 }
 
 /**
- * This is a public static method provided to users that wraps two different checks:
+ * This method provides two different checks:
  *
- * 1. check if IndexedDB is supported by the browser environment.
- * 2. check if the current browser context is valid for using IndexedDB.
+ * 1. Check if IndexedDB exists in the browser environment.
+ * 2. Check if the current browser context allows IndexedDB `open()` calls.
+ * 
+ * @returns A `Promise` which resolves to true if a {@link RemoteConfig} instance
+ * can be initialized in this environment, or false if it cannot.
  * @public
- *
  */
  export async function isSupported(): Promise<boolean> {
   if (!isIndexedDBAvailable()) {