Skip to content

Commit af0c0f8

Browse files
committed
Note auth error callbacks are deprecated
1 parent 61f7112 commit af0c0f8

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

packages/auth/src/model/public_types.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,11 +242,12 @@ export interface Auth {
242242
/**
243243
* Adds an observer for changes to the user's sign-in state.
244244
*
245-
* @remarks
246245
* To keep the old behavior, see {@link Auth.onIdTokenChanged}.
247246
*
248247
* @param nextOrObserver - callback triggered on change.
249-
* @param error - callback triggered on error.
248+
* @param error - Deprecated. This callback is never triggered. Errors
249+
* on signing in/out can be caught in promises returned from
250+
* sign-in/sign-out functions.
250251
* @param completed - callback triggered when observer is removed.
251252
*/
252253
onAuthStateChanged(
@@ -274,7 +275,9 @@ export interface Auth {
274275
* This includes sign-in, sign-out, and token refresh events.
275276
*
276277
* @param nextOrObserver - callback triggered on change.
277-
* @param error - callback triggered on error.
278+
* @param error - Deprecated. This callback is never triggered. Errors
279+
* on signing in/out can be caught in promises returned from
280+
* sign-in/sign-out functions.
278281
* @param completed - callback triggered when observer is removed.
279282
*/
280283
onIdTokenChanged(

0 commit comments

Comments
 (0)