Only appy required test changes

Author: tom-andersen

packages/firestore-compat/test/bundle.test.ts

@@ -188,9 +188,7 @@ apiDescribe('Bundles', (persistence: boolean) => {
       await db.doc('coll-1/b').set({ k: 'b', bar: 0 });
 
       const accumulator = new EventsAccumulator<firestore.QuerySnapshot>();
-      const unsubscribe = db
-        .collection('coll-1')
-        .onSnapshot(accumulator.storeEvent);
+      db.collection('coll-1').onSnapshot(accumulator.storeEvent);
       await accumulator.awaitEvent();
 
       const progress = await db.loadBundle(
@@ -209,8 +207,6 @@ apiDescribe('Bundles', (persistence: boolean) => {
 
       snap = await (await db.namedQuery('limit-to-last'))!.get();
       expect(toDataArray(snap)).to.deep.equal([{ k: 'a', bar: 0 }]);
-
-      unsubscribe();
     });
   });
 

packages/firestore-compat/test/get_options.test.ts

@@ -55,11 +55,11 @@ apiDescribe('GetOptions', (persistence: boolean) => {
 
   it('get document while offline with default get options', () => {
     const initialData = { key: 'value' };
-    return withTestDocAndInitialData(persistence, initialData, async docRef => {
+    return withTestDocAndInitialData(persistence, initialData, docRef => {
       // Register a snapshot to force the data to stay in the cache and not be
       // garbage collected.
-      const unsubscribe = docRef.onSnapshot(() => {});
-      await docRef
+      docRef.onSnapshot(() => {});
+      return docRef
         .get()
         .then(ignored => docRef.firestore.disableNetwork())
         .then(() => docRef.get())
@@ -69,7 +69,6 @@ apiDescribe('GetOptions', (persistence: boolean) => {
           expect(doc.metadata.hasPendingWrites).to.be.false;
           expect(doc.data()).to.deep.equal(initialData);
         });
-      unsubscribe();
     });
   });
 

packages/firestore/test/integration/api/validation.test.ts

@@ -234,8 +234,8 @@ apiDescribe('Validation:', persistence => {
     validationIt(
       persistence,
       'disallows calling enableIndexedDbPersistence() after use',
-      db => {
-        //doc(db, 'foo/bar');
+      async db => {
+        await getDoc(doc(db, 'foo/bar'));
         expect(() => enableIndexedDbPersistence(db)).to.throw(
           'Firestore has already been started and persistence can no ' +
             'longer be enabled. You can only enable persistence before ' +