Skip to content

Commit b1758c4

Browse files
Unbreak .info/serverTimestampOffset (#2061)
1 parent 80d0846 commit b1758c4

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

packages/database/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# Unreleased
2+
- [fixed] Fixed an issue that caused `.info/serverTimeOffset` events not to fire (#2043).
3+
4+
# 6.3.4
25
- [fixed] Fixed an issue where multi-byte UTF-8 characters would not be written correctly when using `firebase.js` or `firebase-database.js` (#2035).
6+
7+
# 6.0.0
38
- [changed] Improved consistency between the type annotations for `Query.on`/`Reference.on`,
49
`Query.off`/`Reference.off` and `Query.once`/`Reference.once` (#1188, #1204).

packages/database/src/core/Repo.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ export class Repo {
274274
}
275275

276276
private onServerInfoUpdate_(updates: Object) {
277-
each(updates, (value: any, key: string) => {
277+
each(updates, (key: string, value: any) => {
278278
this.updateInfo_(key, value);
279279
});
280280
}

packages/database/test/info.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,7 @@ describe('.info Tests', function() {
105105
return ea.promise;
106106
});
107107

108-
// Skipping this test as it is expecting a server time diff from a
109-
// local Firebase
110-
it.skip('.info/serverTimeOffset', async function() {
108+
it('.info/serverTimeOffset', async function() {
111109
const ref = getRootNode() as Reference;
112110

113111
// make sure push works

0 commit comments

Comments
 (0)