Skip to content

Commit b2ac830

Browse files
committed
revert chagnes in yml for testing
1 parent 8fdadd3 commit b2ac830

File tree

1 file changed

+24
-25
lines changed

1 file changed

+24
-25
lines changed

.github/workflows/e2e-test.yml

Lines changed: 24 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ name: E2E Smoke Tests
1616

1717
# Allows REST trigger. Currently triggered by release-cli script during a staging run.
1818
on:
19-
pull_request:
2019
repository_dispatch:
2120
types: [staging-tests,canary-tests]
2221

@@ -31,7 +30,7 @@ jobs:
3130

3231
defaults:
3332
run:
34-
# Run any command steps in the /e2e subdir
33+
# Run any command steps in the /e2e/smoke-tests subdir
3534
working-directory: './e2e/smoke-tests'
3635

3736
steps:
@@ -53,15 +52,15 @@ jobs:
5352
echo "export const config = $PROJECT_CONFIG; export const testAccount = $TEST_ACCOUNT" > firebase-config.js
5453
- name: Poll npm until version to test is available for install
5554
run: |
56-
echo "Polling npm for firebase@11.8.1"
55+
echo "Polling npm for firebase@${{ github.event.client_payload.versionOrTag }}"
5756
node ./scripts/release/poll-npm-publish.js
5857
# run in root
5958
working-directory: '.'
6059
env:
61-
VERSION: 11.8.1
60+
VERSION: ${{ github.event.client_payload.versionOrTag }}
6261
- name: Yarn install
6362
run: |
64-
echo "Installing firebase@11.8.1"
63+
echo "Installing firebase@${{ github.event.client_payload.versionOrTag }}"
6564
6665
yarn
6766
- name: Deploy "callTest" cloud function
@@ -85,23 +84,23 @@ jobs:
8584
env:
8685
APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}
8786
run: xvfb-run yarn test:compat
88-
# - name: Tests succeeded
89-
# if: success()
90-
# run: node scripts/ci/notify-test-result.js success
91-
# # we don't want THIS step erroring to trigger the failure notification
92-
# continue-on-error: true
93-
# env:
94-
# WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
95-
# RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}
96-
# VERSION_OR_TAG: 11.8.1
97-
# # run in root
98-
# working-directory: '.'
99-
# - name: Tests failed
100-
# if: failure()
101-
# run: node scripts/ci/notify-test-result.js fail
102-
# env:
103-
# WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
104-
# RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}
105-
# VERSION_OR_TAG: ${{ github.event.client_payload.versionOrTag }}
106-
# # run in root
107-
# working-directory: '.'
87+
- name: Tests succeeded
88+
if: success()
89+
run: node scripts/ci/notify-test-result.js success
90+
# we don't want THIS step erroring to trigger the failure notification
91+
continue-on-error: true
92+
env:
93+
WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
94+
RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}
95+
VERSION_OR_TAG: ${{ github.event.client_payload.versionOrTag }}
96+
# run in root
97+
working-directory: '.'
98+
- name: Tests failed
99+
if: failure()
100+
run: node scripts/ci/notify-test-result.js fail
101+
env:
102+
WEBHOOK_URL: ${{ secrets.JSCORE_CHAT_WEBHOOK_URL }}
103+
RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}
104+
VERSION_OR_TAG: ${{ github.event.client_payload.versionOrTag }}
105+
# run in root
106+
working-directory: '.'

0 commit comments

Comments
 (0)