Specify readonly as the default indexeddb transaction mode

tmrudick · tmrudick · commit b50d1b3a3fcb · 2022-04-05T22:30:52.000-04:00
While the mode parameter is optional, the wrapper method will pass `undefined` into the native method if it is not passed into the wrapper. IE11 interprets this as a mode instead of ignoring it and throws an InvalidAccessError.

Specifying `readonly` as the default (which is the default if the parameter is omitted) prevents IE11 from crashing during initialization.
diff --git a/packages/util/src/indexeddb.ts b/packages/util/src/indexeddb.ts
@@ -42,7 +42,7 @@ export class DBWrapper {
   }
   transaction(
     storeNames: string[] | string,
-    mode?: IDBTransactionMode
+    mode: IDBTransactionMode = 'readonly'
   ): TransactionWrapper {
     return new TransactionWrapper(
       this._db.transaction.call(this._db, storeNames, mode)

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ export class DBWrapper {`
`42`	`42`	`}`
`43`	`43`	`transaction(`
`44`	`44`	`storeNames: string[] \| string,`
`45`		`- mode?: IDBTransactionMode`
	`45`	`+ mode: IDBTransactionMode = 'readonly'`
`46`	`46`	`): TransactionWrapper {`
`47`	`47`	`return new TransactionWrapper(`
`48`	`48`	`this._db.transaction.call(this._db, storeNames, mode)`