fix ts errors

Author: Feiyang1

packages/database/rollup.config.exp.js

@@ -21,7 +21,8 @@ import typescript from 'typescript';
 import path from 'path';
 import { importPathTransformer } from '../../scripts/exp/ts-transform-import-path';
 
-import pkg from './exp/package.json';
+import expPkg from './exp/package.json';
+import pkg from './package.json';
 
 const deps = Object.keys(
   Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -46,7 +47,7 @@ const es5Builds = [
   {
     input: 'exp/index.ts',
     output: [
-      { file: path.resolve('exp', pkg.main), format: 'cjs', sourcemap: true }
+      { file: path.resolve('exp', expPkg.main), format: 'cjs', sourcemap: true }
     ],
     plugins: es5BuildPlugins,
     treeshake: {
@@ -60,7 +61,11 @@ const es5Builds = [
   {
     input: 'exp/index.ts',
     output: [
-      { file: path.resolve('exp', pkg.module), format: 'es', sourcemap: true }
+      {
+        file: path.resolve('exp', expPkg.module),
+        format: 'es',
+        sourcemap: true
+      }
     ],
     plugins: es5BuildPlugins,
     treeshake: {
@@ -94,7 +99,11 @@ const es2017Builds = [
   {
     input: 'exp/index.ts',
     output: [
-      { file: path.resolve('exp', pkg.esm2017), format: 'es', sourcemap: true }
+      {
+        file: path.resolve('exp', expPkg.esm2017),
+        format: 'es',
+        sourcemap: true
+      }
     ],
     plugins: es2017BuildPlugins,
     treeshake: {

packages/firestore/src/util/byte_stream.ts

@@ -40,23 +40,21 @@ export function toByteStreamReaderHelper(
   );
   let readFrom = 0;
   const reader: ReadableStreamReader<Uint8Array> = {
-    async read(): Promise<ReadableStreamReadResult<Uint8Array>> {
+    async read(): Promise<ReadableStreamDefaultReadResult<Uint8Array>> {
       if (readFrom < source.byteLength) {
         const result = {
           value: source.slice(readFrom, readFrom + bytesPerRead),
           done: false
-        };
+        } as const;
         readFrom += bytesPerRead;
         return result;
       }
 
-      // TypesScript's lib.dom.d.ts doesn't have proper typings of
-      // ReadableStreamReadResult yet.
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       return { done: true } as any;
     },
     async cancel(): Promise<void> {},
-    releaseLock() {}
+    releaseLock() {},
+    closed: Promise.reject('unimplemented')
   };
   return reader;
 }

packages/firestore/src/util/node_api.ts

@@ -58,12 +58,12 @@ export function nodePromise<R>(
   action: (callback: NodeCallback<R>) => void
 ): Promise<R> {
   return new Promise(
-    (resolve: (value?: R) => void, reject: (error?: unknown) => void) => {
+    (resolve: (value: R) => void, reject: (error?: unknown) => void) => {
       action((error?: unknown, value?: R) => {
         if (error) {
           reject(error);
         } else {
-          resolve(value);
+          resolve(value!);
         }
       });
     }

packages/firestore/src/util/promise.ts

@@ -16,7 +16,7 @@
  */
 
 export interface Resolver<R> {
-  (value?: R | Promise<R>): void;
+  (value: R | Promise<R>): void;
 }
 
 export interface Rejecter {

packages/logger/package.json

@@ -21,6 +21,9 @@
     "test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha test/**/*.test.* --config ../../config/mocharc.node.js"
   },
   "license": "Apache-2.0",
+  "dependencies": {
+    "tslib": "^2.0.0"
+  },
   "devDependencies": {
     "rollup": "2.35.1",
     "rollup-plugin-typescript2": "0.29.0",