Skip to content

Commit b8ec2e0

Browse files
XuechunHouhsubox76
authored andcommitted
addressed PR comments
1 parent 8e71b56 commit b8ec2e0

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

packages/firebase/compat/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2032,8 +2032,8 @@ declare namespace firebase.remoteConfig {
20322032
*/
20332033
export type LogLevel = 'debug' | 'error' | 'silent';
20342034
/**
2035-
* An async function that returns true if current browser context supports
2036-
* initialization of `RemoteConfig` instance (`firebase.remoteConfig()`).
2035+
* Returns true if current browser context supports
2036+
* initialization of a `RemoteConfig` instance (`firebase.remoteConfig()`).
20372037
*
20382038
* Returns false otherwise.
20392039
*/

packages/remote-config/src/errors.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export const enum ErrorCode {
3131
FETCH_THROTTLE = 'fetch-throttle',
3232
FETCH_PARSE = 'fetch-client-parse',
3333
FETCH_STATUS = 'fetch-status',
34-
INDEXED_DB_UNSUPPORTED = 'indexed-db-unsupported'
34+
INDEXED_DB_UNAVAILABLE = 'indexed-db-unavailable'
3535
}
3636

3737
const ERROR_DESCRIPTION_MAP: { readonly [key in ErrorCode]: string } = {
@@ -66,7 +66,7 @@ const ERROR_DESCRIPTION_MAP: { readonly [key in ErrorCode]: string } = {
6666
' Original error: {$originalErrorMessage}.',
6767
[ErrorCode.FETCH_STATUS]:
6868
'Fetch server returned an HTTP error status. HTTP status: {$httpStatus}.',
69-
[ErrorCode.INDEXED_DB_UNSUPPORTED]:
69+
[ErrorCode.INDEXED_DB_UNAVAILABLE]:
7070
'Indexed DB is not supported by current browser'
7171
};
7272

packages/remote-config/src/register.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export function registerRemoteConfig(): void {
7373
}
7474
// Guards against the SDK being used when indexedDB is not available.
7575
if (!isIndexedDBAvailable()) {
76-
throw ERROR_FACTORY.create(ErrorCode.INDEXED_DB_UNSUPPORTED);
76+
throw ERROR_FACTORY.create(ErrorCode.INDEXED_DB_UNAVAILABLE);
7777
}
7878
// Normalizes optional inputs.
7979
const { projectId, apiKey, appId } = app.options;

0 commit comments

Comments
 (0)