enable no-explicit-any in test files

Author: Feiyang1

packages/firestore/.eslintrc.json

@@ -16,5 +16,16 @@
                 "args": "none"
             }
         ]
-    }
+    },
+    "overrides": [
+        {
+            "files": [
+                "**/*.test.ts",
+                "**/test/**/*.ts"
+            ],
+            "rules": {
+                "@typescript-eslint/no-explicit-any": "error"
+            }
+        }
+    ]
 }

packages/firestore/test/integration/api/database.test.ts

@@ -517,9 +517,9 @@ apiDescribe('Database', (persistence: boolean) => {
     for (const val of invalidDocValues) {
       it('set/update should reject: ' + val, () => {
         return withTestDoc(persistence, async doc => {
-          // tslint:disable-next-line:no-any Intentionally passing bad types.
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any, Intentionally passing bad types.
           expect(() => doc.set(val as any)).to.throw();
-          // tslint:disable-next-line:no-any Intentionally passing bad types.
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any, Intentionally passing bad types.
           expect(() => doc.update(val as any)).to.throw();
         });
       });

packages/firestore/test/integration/api/fields.test.ts

@@ -31,7 +31,7 @@ const FieldPath = firebase.firestore!.FieldPath;
 const FieldValue = firebase.firestore!.FieldValue;
 const Timestamp = firebase.firestore!.Timestamp;
 
-// tslint:disable-next-line:no-any Allow custom types for testing.
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, Allow custom types for testing.
 type AnyTestData = any;
 
 apiDescribe('Nested Fields', (persistence: boolean) => {
@@ -346,7 +346,7 @@ apiDescribe('Fields with special characters', (persistence: boolean) => {
 });
 
 apiDescribe('Timestamp Fields in snapshots', (persistence: boolean) => {
-  // tslint:disable-next-line:no-any Figure out how to pass in the Timestamp type
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any, Figure out how to pass in the Timestamp type
   const testDataWithTimestamps = (ts: any): AnyTestData => {
     return { timestamp: ts, nested: { timestamp2: ts } };
   };

packages/firestore/test/integration/api/query.test.ts

@@ -627,7 +627,7 @@ apiDescribe('Queries', (persistence: boolean) => {
     const expectedError =
       'QuerySnapshot.docChanges has been changed from a property into a method';
 
-    // tslint:disable-next-line:no-any We are testing invalid API usage.
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any, We are testing invalid API usage.
     const docChange = querySnap.docChanges as any;
     expect(() => docChange.length).to.throw(expectedError);
     expect(() => {

packages/firestore/test/integration/api/server_timestamp.test.ts

@@ -24,7 +24,7 @@ import { apiDescribe, withTestDoc } from '../util/helpers';
 
 // tslint:disable:no-floating-promises
 
-// tslint:disable-next-line:no-any Allow custom types for testing.
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, Allow custom types for testing.
 type AnyTestData = any;
 
 const Timestamp = firebase.firestore!.Timestamp;

packages/firestore/test/integration/api/transactions.test.ts

@@ -487,7 +487,7 @@ apiDescribe('Database transactions', (persistence: boolean) => {
 
     for (const badReturn of badReturns) {
       it(badReturn + ' is rejected', () => {
-        // tslint:disable-next-line:no-any Intentionally returning bad type.
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any, Intentionally returning bad type.
         const fn = ((txn: firestore.Transaction) => badReturn) as any;
         return integrationHelpers.withTestDb(persistence, db => {
           return db

packages/firestore/test/integration/api/validation.test.ts

@@ -38,7 +38,7 @@ const FieldPath = firebase.firestore!.FieldPath;
 const FieldValue = firebase.firestore!.FieldValue;
 
 // We're using 'as any' to pass invalid values to APIs for testing purposes.
-// tslint:disable:no-any
+/* eslint-disable @typescript-eslint/no-explicit-any */
 
 interface ValidationIt {
   (

packages/firestore/test/integration/bootstrap.ts

@@ -25,6 +25,7 @@ import '../../index';
  */
 
 // 'context()' definition requires additional dependency on webpack-env package.
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const testsContext = (require as any).context('.', true, /.test$/);
 const browserTests = testsContext
   .keys()

packages/firestore/test/integration/util/helpers.ts

@@ -24,7 +24,7 @@ import firebase from './firebase_export';
  * dependencies on src/ files.
  */
 
-// __karma__ is an untyped global
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, __karma__ is an untyped global
 declare const __karma__: any;
 
 // eslint-disable-next-line @typescript-eslint/no-require-imports

packages/firestore/test/unit/api/blob.test.ts

@@ -58,7 +58,7 @@ describe('Blob', () => {
   });
 
   it('Blob throws on using the public constructor', () => {
-    // tslint:disable-next-line:no-any allow using constructor with any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any, allow using constructor with any
     expect(() => new (PublicBlob as any)('')).to.throw(
       'This constructor is private. Use Blob.fromUint8Array() or ' +
         'Blob.fromBase64String() instead.'

packages/firestore/test/unit/bootstrap.ts

@@ -25,6 +25,7 @@ import '../../src/platform_browser/browser_init';
  */
 
 // 'context()' definition requires additional dependency on webpack-env package.
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const testsContext = (require as any).context('.', true, /.test$/);
 const browserTests = testsContext
   .keys()

packages/firestore/test/unit/core/event_manager.test.ts

@@ -39,7 +39,7 @@ import {
 } from '../../util/helpers';
 
 describe('EventManager', () => {
-  // tslint:disable-next-line:no-any mock object.
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any, mock object.
   function fakeQueryListener(query: Query): any {
     return {
       query,
@@ -49,7 +49,7 @@ describe('EventManager', () => {
     };
   }
 
-  // tslint:disable-next-line:no-any mock object.
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any, mock object.
   function makeSyncEngineSpy(): any {
     const stub = {
       listen: sinon.stub().returns(Promise.resolve(0)),
@@ -115,9 +115,9 @@ describe('EventManager', () => {
     await eventManager.listen(fakeListener3);
     expect(syncEngineSpy.listen.callCount).to.equal(2);
 
-    // tslint:disable-next-line:no-any mock ViewSnapshot.
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any, mock ViewSnapshot.
     const viewSnap1: any = { query: query1 };
-    // tslint:disable-next-line:no-any mock ViewSnapshot.
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any, mock ViewSnapshot.
     const viewSnap2: any = { query: query2 };
     eventManager.onWatchChange([viewSnap1, viewSnap2]);
 

packages/firestore/test/unit/local/indexeddb_persistence.test.ts

@@ -228,7 +228,7 @@ describe('IndexedDbSchema: createOrUpgradeDb', () => {
 
           return (
             targets
-              // tslint:disable-next-line:no-any
+              // eslint-disable-next-line @typescript-eslint/no-explicit-any
               .put({ targetId, canonicalId: 'foo' } as any)
               .next(() =>
                 targetGlobal.put(DbTargetGlobal.key, dummyTargetGlobal)
@@ -335,7 +335,7 @@ describe('IndexedDbSchema: createOrUpgradeDb', () => {
           );
           p = p.next(() => {
             store
-              .add({} as any) // tslint:disable-line:no-any
+              .add({} as any) // eslint-disable-line @typescript-eslint/no-explicit-any
               .next(batchId => {
                 expect(batchId).to.equal(43);
               });

packages/firestore/test/unit/local/lru_garbage_collector.test.ts

@@ -122,7 +122,7 @@ function genericLruGarbageCollectorTests(
     );
     const referenceDelegate = persistence.referenceDelegate;
     referenceDelegate.setInMemoryPins(new ReferenceSet());
-    // tslint:disable-next-line:no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     garbageCollector = ((referenceDelegate as any) as LruDelegate)
       .garbageCollector;
   }

packages/firestore/test/unit/local/web_storage_shared_client_state.test.ts

@@ -645,7 +645,7 @@ describe('WebStorageSharedClientState', () => {
           new MutationMetadata(
             AUTHENTICATED_USER,
             1,
-            'invalid' as any // tslint:disable-line:no-any
+            'invalid' as any // eslint-disable-line @typescript-eslint/no-explicit-any
           ).toWebStorageJSON()
         );
       }).then(clientState => {
@@ -802,7 +802,7 @@ describe('WebStorageSharedClientState', () => {
           targetKey(firstClientTargetId),
           new QueryTargetMetadata(
             firstClientTargetId,
-            'invalid' as any // tslint:disable-line:no-any
+            'invalid' as any // eslint-disable-line @typescript-eslint/no-explicit-any
           ).toWebStorageJSON()
         );
       }).then(clientState => {

packages/firestore/test/unit/remote/node/serializer.test.ts

@@ -1181,7 +1181,7 @@ describe('Serializer', () => {
     addEqualityMatcher();
 
     it('contains all Operators', () => {
-      // tslint:disable-next-line:no-any giant hack
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any, giant hack
       obj.forEach(Operator as any, (name, op) => {
         if (op instanceof Operator) {
           expect(s.toOperatorName(op), 'for name').to.exist;
@@ -1195,7 +1195,7 @@ describe('Serializer', () => {
     addEqualityMatcher();
 
     it('contains all Directions', () => {
-      // tslint:disable-next-line:no-any giant hack
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any, giant hack
       obj.forEach(Direction as any, (name, dir) => {
         if (dir instanceof Direction) {
           expect(s.toDirection(dir), 'for ' + name).to.exist;

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -258,7 +258,7 @@ class MockConnection implements Connection {
         }
       });
       this.writeStream = writeStream;
-      // Replace 'any' with conditional types.
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any, Replace 'any' with conditional types.
       return writeStream as any;
     } else {
       assert(rpcName === 'Listen', 'Unexpected rpc name: ' + rpcName);
@@ -292,7 +292,7 @@ class MockConnection implements Connection {
         }
       });
       this.watchStream = watchStream;
-      // Replace 'any' with conditional types.
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any, Replace 'any' with conditional types.
       return this.watchStream as any;
     }
   }

packages/firestore/test/util/helpers.ts

@@ -556,7 +556,7 @@ export class DocComparator {
 /**
  * Two helper functions to simplify testing isEqual() method.
  */
-// use any type so we can dynamically call .isEqual().
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, so we can dynamically call .isEqual().
 export function expectEqual(left: any, right: any, message?: string): void {
   message = message || '';
   if (typeof left.isEqual !== 'function') {
@@ -573,7 +573,7 @@ export function expectEqual(left: any, right: any, message?: string): void {
   expect(right.isEqual(left)).to.equal(true, message);
 }
 
-// use any so we can dynamically call .isEqual().
+// eslint-disable-next-line @typescript-eslint/no-explicit-any, so we can dynamically call .isEqual().
 export function expectNotEqual(left: any, right: any, message?: string): void {
   expect(left.isEqual(right)).to.equal(false, message || '');
   expect(right.isEqual(left)).to.equal(false, message || '');

packages/firestore/test/util/node_persistence.ts

@@ -29,6 +29,7 @@ import { FakeWindow, SharedFakeWebStorage } from './test_platform';
 // To use this code to run persistence-based tests in Node, include this module
 // and set the environment variable `USE_MOCK_PERSISTENCE` to `YES`.
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any,
 const globalAny = global as any;
 
 const dbDir = fs.mkdtempSync(os.tmpdir() + '/firestore_tests');

packages/firestore/test/util/test_platform.ts

@@ -199,7 +199,7 @@ export class SharedFakeWebStorage {
         oldValue,
         newValue,
         storageArea: client.storageArea
-      } as any); // Not mocking entire Event type.
+      } as any); // eslint-disable-line @typescript-eslint/no-explicit-any, Not mocking entire Event type.
     });
   }
 }
@@ -220,12 +220,12 @@ export class TestPlatform implements Platform {
   }
 
   get document(): Document | null {
-    // FakeWindow doesn't support full Document interface.
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any, FakeWindow doesn't support full Document interface.
     return this.mockDocument as any;
   }
 
   get window(): Window | null {
-    // FakeWindow doesn't support full Window interface.
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any, FakeWindow doesn't support full Window interface.
     return this.mockWindow as any;
   }