misc changes

Author: Feiyang1

packages/firestore/externs.json

@@ -14,6 +14,7 @@
     "node_modules/typescript/lib/lib.es2017.string.d.ts",
     "packages/app-types/index.d.ts",
     "packages/app-types/private.d.ts",
+    "packages-exp/app-exp/dist/app-exp.d.ts",
     "packages-exp/app-types-exp/index.d.ts",
     "packages/auth-interop-types/index.d.ts",
     "packages/firestore/exp-types/index.d.ts",

packages/firestore/rollup.config.exp.release.js

@@ -57,7 +57,7 @@ const minifiedPlugins = [
     },
     clean: true,
     abortOnError: false,
-    transformers: [...firestoreTransformers, importPathTransformer]
+    transformers: [importPathTransformer, ...firestoreTransformers]
   }),
   json({ preferConst: true }),
   terser(manglePrivatePropertiesOptions)
@@ -72,7 +72,10 @@ const allBuilds = [
       format: 'es'
     },
     plugins: [alias(generateAliasConfig('node')), ...plugins],
-    external: resolveNodeExterns
+    external: resolveNodeExterns,
+    treeshake: {
+      moduleSideEffects: false
+    }
   },
   // Browser build
   {
@@ -82,7 +85,10 @@ const allBuilds = [
       format: 'es'
     },
     plugins: [alias(generateAliasConfig('browser')), ...minifiedPlugins],
-    external: resolveBrowserExterns
+    external: resolveBrowserExterns,
+    treeshake: {
+      moduleSideEffects: false
+    }
   },
   // RN build
   {
@@ -92,7 +98,10 @@ const allBuilds = [
       format: 'es'
     },
     plugins: [alias(generateAliasConfig('rn')), ...minifiedPlugins],
-    external: resolveBrowserExterns
+    external: resolveBrowserExterns,
+    treeshake: {
+      moduleSideEffects: false
+    }
   }
 ];
 

packages/firestore/rollup.config.lite.release.js

@@ -57,7 +57,7 @@ const minifiedPlugins = [
     },
     clean: true,
     abortOnError: false,
-    transformers: [...firestoreTransformers, importPathTransformer]
+    transformers: [importPathTransformer, ...firestoreTransformers]
   }),
   json({ preferConst: true }),
   terser(manglePrivatePropertiesOptions)
@@ -72,7 +72,10 @@ const allBuilds = [
       format: 'es'
     },
     plugins: [alias(generateAliasConfig('node')), ...plugins],
-    external: resolveNodeExterns
+    external: resolveNodeExterns,
+    treeshake: {
+      moduleSideEffects: false
+    }
   },
   // Browser build
   {
@@ -82,7 +85,10 @@ const allBuilds = [
       format: 'es'
     },
     plugins: [alias(generateAliasConfig('browser')), ...minifiedPlugins],
-    external: resolveBrowserExterns
+    external: resolveBrowserExterns,
+    treeshake: {
+      moduleSideEffects: false
+    }
   },
   // RN build
   {
@@ -92,7 +98,10 @@ const allBuilds = [
       format: 'es'
     },
     plugins: [alias(generateAliasConfig('rn')), ...minifiedPlugins],
-    external: resolveBrowserExterns
+    external: resolveBrowserExterns,
+    treeshake: {
+      moduleSideEffects: false
+    }
   }
 ];
 

scripts/exp/prepare-firestore-for-exp-release.ts

@@ -19,6 +19,7 @@ import { spawn } from 'child-process-promise';
 import { projectRoot, readPackageJson } from '../utils';
 import { writeFile as _writeFile } from 'fs';
 import { promisify } from 'util';
+import { removeExpSuffix } from './remove-exp';
 const writeFile = promisify(_writeFile);
 const packagePath = `${projectRoot}/packages/firestore`;
 
@@ -58,4 +59,8 @@ export async function prepare() {
     `${JSON.stringify(packageJson, null, 2)}\n`,
     { encoding: 'utf-8' }
   );
+
+  // remove -exp in typings files
+  removeExpSuffix(`${packagePath}/exp-types`);
+  removeExpSuffix(`${packagePath}/lite-types`);
 }