Addressing review comments and adding some Unit test

mansisampat · mansisampat · commit bf98477d03a7 · 2025-05-22T11:40:11.000+05:30
diff --git a/packages/auth/src/core/auth/auth_impl.ts b/packages/auth/src/core/auth/auth_impl.ts
@@ -93,6 +93,7 @@ export const enum DefaultConfig {
   TOKEN_API_HOST = 'securetoken.googleapis.com',
   API_HOST = 'identitytoolkit.googleapis.com',
   API_SCHEME = 'https',
+  // TODO(sammansi): Update the endpoint before BYO-CIAM Private Preview Release.
   REGIONAL_API_HOST = 'identityplatform.googleapis.com/v2alpha/'
 }
 
diff --git a/packages/auth/src/core/strategies/exhange_token.ts b/packages/auth/src/core/strategies/exhange_token.ts
@@ -24,7 +24,7 @@ import { _castAuth } from '../auth/auth_impl';
 
 /**
  * Asynchronously exchanges an OIDC provider's Authorization code or Id Token
- * for an OidcToken i.e. Outbound Access Token.
+ * for a Firebase Token.
  *
  * @remarks
  * This method is implemented only for `DefaultConfig.REGIONAL_API_HOST` and

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ export const enum DefaultConfig {`
`93`	`93`	`TOKEN_API_HOST = 'securetoken.googleapis.com',`
`94`	`94`	`API_HOST = 'identitytoolkit.googleapis.com',`
`95`	`95`	`API_SCHEME = 'https',`
	`96`	`+ // TODO(sammansi): Update the endpoint before BYO-CIAM Private Preview Release.`
`96`	`97`	`REGIONAL_API_HOST = 'identityplatform.googleapis.com/v2alpha/'`
`97`	`98`	`}`
`98`	`99`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ import { _castAuth } from '../auth/auth_impl';`
`24`	`24`
`25`	`25`	`/**`
`26`	`26`	`* Asynchronously exchanges an OIDC provider's Authorization code or Id Token`
`27`		`- * for an OidcToken i.e. Outbound Access Token.`
	`27`	`+ * for a Firebase Token.`
`28`	`28`	`*`
`29`	`29`	`* @remarks`
`30`	`30`	* This method is implemented only for `DefaultConfig.REGIONAL_API_HOST` and