Skip to content

Commit c1437bc

Browse files
committed
firestore-compat: fix typing error in fields.test.ts: TS2339: Property 'ignoreUndefinedProperties' does not exist on type '{ host: string; ssl: boolean; }'
See https://github.com/firebase/firebase-js-sdk/actions/runs/4367447223/jobs/7638769445
1 parent 266a722 commit c1437bc

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

packages/firestore-compat/test/fields.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ apiDescribe('Timestamp Fields in snapshots', (persistence: boolean) => {
387387
});
388388

389389
apiDescribe('`undefined` properties', (persistence: boolean) => {
390-
const settings = { ...DEFAULT_SETTINGS };
390+
const settings: firebaseExport.Settings = { ...DEFAULT_SETTINGS };
391391
settings.ignoreUndefinedProperties = true;
392392

393393
it('are ignored in set()', () => {

packages/firestore-compat/test/util/firebase_export.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import firebase from '@firebase/app-compat';
2424
import { FirebaseApp } from '@firebase/app-types';
2525
import { GeoPoint, Timestamp } from '@firebase/firestore';
26-
import * as firestore from '@firebase/firestore-types';
26+
import { FirebaseFirestore, Settings } from '@firebase/firestore-types';
2727

2828
import { Blob } from '../../src/api/blob';
2929
import {
@@ -45,8 +45,8 @@ let appCount = 0;
4545
export function newTestFirestore(
4646
projectId: string,
4747
nameOrApp?: string | FirebaseApp,
48-
settings?: firestore.Settings
49-
): firestore.FirebaseFirestore {
48+
settings?: Settings
49+
): FirebaseFirestore {
5050
if (nameOrApp === undefined) {
5151
nameOrApp = 'test-app-' + appCount++;
5252
}
@@ -78,5 +78,6 @@ export {
7878
Blob,
7979
GeoPoint,
8080
DocumentReference,
81-
QueryDocumentSnapshot
81+
QueryDocumentSnapshot,
82+
Settings
8283
};

0 commit comments

Comments
 (0)