Skip to content

Commit c4d63b1

Browse files
committed
Address some PR comments
1 parent effc1bd commit c4d63b1

File tree

13 files changed

+19
-17
lines changed

13 files changed

+19
-17
lines changed

docs-devsite/analytics.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ https://github.com/firebase/firebase-js-sdk
1010
{% endcomment %}
1111

1212
# analytics package
13-
The Firebase Analytics Web SDK. This SDK currently does not work in Node.js.
13+
The Firebase Analytics Web SDK. This SDK does not work in Node.js.
1414

1515
## Functions
1616

docs-devsite/auth.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -696,6 +696,8 @@ Changes the type of persistence on the [Auth](./auth.auth.md#auth_interface) ins
696696

697697
This makes it easy for a user signing in to specify whether their session should be remembered or not. It also makes it easier to never persist the `Auth` state for applications that are shared by other users or have sensitive data.
698698

699+
This method has no effect in Node.js.
700+
699701
<b>Signature:</b>
700702

701703
```typescript
@@ -722,7 +724,6 @@ A `Promise` that resolves once the persistence change has completed
722724
setPersistence(auth, browserSessionPersistence);
723725

724726
```
725-
This method has no effect in Node.js.
726727

727728
## signInAnonymously()
728729

docs-devsite/index.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ https://github.com/firebase/firebase-js-sdk
1515

1616
| Package | Description |
1717
| --- | --- |
18-
| [@firebase/analytics](./analytics.md#analytics_package) | The Firebase Analytics Web SDK. This SDK currently does not work in Node.js. |
18+
| [@firebase/analytics](./analytics.md#analytics_package) | The Firebase Analytics Web SDK. This SDK does not work in Node.js. |
1919
| [@firebase/app](./app.md#app_package) | Firebase App |
2020
| [@firebase/app-check](./app-check.md#app-check_package) | The Firebase App Check Web SDK. |
2121
| [@firebase/auth](./auth.md#auth_package) | Firebase Authentication |
2222
| [@firebase/database](./database.md#database_package) | Firebase Realtime Database |
2323
| [@firebase/firestore](./firestore.md#firestore_package) | Cloud Firestore |
2424
| [@firebase/functions](./functions.md#functions_package) | Cloud Functions for Firebase |
25-
| [@firebase/installations](./installations.md#installations_package) | The Firebase Installations Web SDK. This SDK currently does not work in Node.js. |
26-
| [@firebase/messaging](./messaging.md#messaging_package) | The Firebase Cloud Messaging Web SDK. This SDK currently does not work in Node.js. |
27-
| [@firebase/performance](./performance.md#performance_package) | The Firebase Performance Monitoring Web SDK. This SDK currently does not work in Node.js. |
28-
| [@firebase/remote-config](./remote-config.md#remote-config_package) | The Firebase Remote Config Web SDK. This SDK currently does not work in Node.js. |
25+
| [@firebase/installations](./installations.md#installations_package) | The Firebase Installations Web SDK. This SDK does not work in Node.js. |
26+
| [@firebase/messaging](./messaging.md#messaging_package) | The Firebase Cloud Messaging Web SDK. This SDK does not work in Node.js. |
27+
| [@firebase/performance](./performance.md#performance_package) | The Firebase Performance Monitoring Web SDK. This SDK does not work in Node.js. |
28+
| [@firebase/remote-config](./remote-config.md#remote-config_package) | The Firebase Remote Config Web SDK. This SDK does not work in Node.js. |
2929
| [@firebase/storage](./storage.md#storage_package) | Cloud Storage for Firebase |
3030

docs-devsite/installations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ https://github.com/firebase/firebase-js-sdk
1010
{% endcomment %}
1111

1212
# installations package
13-
The Firebase Installations Web SDK. This SDK currently does not work in Node.js.
13+
The Firebase Installations Web SDK. This SDK does not work in Node.js.
1414

1515
## Functions
1616

docs-devsite/messaging.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ https://github.com/firebase/firebase-js-sdk
1010
{% endcomment %}
1111

1212
# messaging package
13-
The Firebase Cloud Messaging Web SDK. This SDK currently does not work in Node.js.
13+
The Firebase Cloud Messaging Web SDK. This SDK does not work in Node.js.
1414

1515
| Entry Point | Description |
1616
| --- | --- |

docs-devsite/performance.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ https://github.com/firebase/firebase-js-sdk
1010
{% endcomment %}
1111

1212
# performance package
13-
The Firebase Performance Monitoring Web SDK. This SDK currently does not work in Node.js.
13+
The Firebase Performance Monitoring Web SDK. This SDK does not work in Node.js.
1414

1515
## Functions
1616

docs-devsite/remote-config.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ https://github.com/firebase/firebase-js-sdk
1010
{% endcomment %}
1111

1212
# remote-config package
13-
The Firebase Remote Config Web SDK. This SDK currently does not work in Node.js.
13+
The Firebase Remote Config Web SDK. This SDK does not work in Node.js.
1414

1515
## Functions
1616

packages/analytics/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* The Firebase Analytics Web SDK.
3-
* This SDK currently does not work in Node.js.
3+
* This SDK does not work in Node.js.
44
*
55
* @packageDocumentation
66
*/

packages/auth/src/core/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,12 @@ export {
4444
* remembered or not. It also makes it easier to never persist the `Auth` state for applications
4545
* that are shared by other users or have sensitive data.
4646
*
47+
* This method has no effect in Node.js.
48+
*
4749
* @example
4850
* ```javascript
4951
* setPersistence(auth, browserSessionPersistence);
5052
* ```
51-
* This method has no effect in Node.js.
5253
*
5354
* @param auth - The {@link Auth} instance.
5455
* @param persistence - The {@link Persistence} to use.

packages/installations/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* The Firebase Installations Web SDK.
3-
* This SDK currently does not work in Node.js.
3+
* This SDK does not work in Node.js.
44
*
55
* @packageDocumentation
66
*/

packages/messaging/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* The Firebase Cloud Messaging Web SDK.
3-
* This SDK currently does not work in Node.js.
3+
* This SDK does not work in Node.js.
44
*
55
* @packageDocumentation
66
*/

packages/performance/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* The Firebase Performance Monitoring Web SDK.
3-
* This SDK currently does not work in Node.js.
3+
* This SDK does not work in Node.js.
44
*
55
* @packageDocumentation
66
*/

packages/remote-config/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* The Firebase Remote Config Web SDK.
3-
* This SDK currently does not work in Node.js.
3+
* This SDK does not work in Node.js.
44
*
55
* @packageDocumentation
66
*/

0 commit comments

Comments
 (0)