more output

Author: DellaBitta

.github/workflows/test-all.yml

@@ -41,15 +41,6 @@ jobs:
     - name: install Chrome stable
       run: |
         npx @puppeteer/browsers install chrome@stable
-        chromeVersionString=$(ls chrome)
-        if [ "$CHROME_VALIDATED_VERSION" != "$chromeVersionString" ]; then 
-        echo "::warning ::The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass."
-        echo "::warning ::Previously validated version: ${CHROME_VALIDATED_VERSION} vs. Installed version: $chromeVersionString"
-        echo "CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE" >> "$GITHUB_ENV"
-        fi
-    - name: Test Evn TEMP
-      run: |
-        echo $CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE
     - uses: actions/checkout@v3
     - name: Set up Node (16)
       uses: actions/setup-node@v3
@@ -126,6 +117,15 @@ jobs:
     - name: install Chrome stable
       run: |
         npx @puppeteer/browsers install chrome@stable
+        chromeVersionString=$(ls chrome)
+        if [ "$CHROME_VALIDATED_VERSION" != "$chromeVersionString" ]; then
+        echo "::warning ::The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass."
+        echo "::warning ::Previously validated version: ${CHROME_VALIDATED_VERSION} vs. Installed version: $chromeVersionString"
+        echo "CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE" >> "$GITHUB_ENV"
+        fi
+    - name: Test Evn TEMP
+      run: |
+        echo $CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE
     - name: Download build archive
       uses: actions/download-artifact@v3
       with:

.github/workflows/test-changed-auth.yml

@@ -24,26 +24,25 @@ env:
   CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/
   CHROMEDRIVER_CDNBINARIESURL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/
   CHROME_VALIDATED_VERSION: blinux-120.0.6099.71
-  CHROME_VERSION_MISMATCH_MESSAGE: "The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass."
   # Bump Node memory limit
   NODE_OPTIONS: "--max_old_space_size=4096"
 
 jobs:
   test-chrome:
     name: Test Auth on Chrome and Node If Changed
     runs-on: ubuntu-latest
-
     steps:
       # install Chrome first, so the correct version of webdriver can be installed by chromedriver
       # when setting up the repo
       #
       # Note: we only need to check the chrome version change in one job as the warning annotation
       # is appended to the entire workflow results, not just this job's results.
       - name: install Chrome stable
+        env: env: CHROME_VERSION_MISMATCH_MESSAGE: "The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass."
         run: |
           npx @puppeteer/browsers install chrome@stable
           chromeVersionString=$(ls chrome)
-          if [ "$CHROME_VALIDATED_VERSION" != "$chromeVersionString" ]; then 
+          if [ "$CHROME_VALIDATED_VERSION" != "$chromeVersionString" ]; then
           echo "::warning ::The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass."
           echo "::warning ::Previously validated version: ${CHROME_VALIDATED_VERSION} vs. Installed version: $chromeVersionString"
           echo "CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE" >> "$GITHUB_ENV"

scripts/ci-test/test_changed.ts

@@ -80,6 +80,14 @@ async function runTests(config: TestConfig) {
     process.exit(0);
   } catch (e) {
     console.error(chalk`{red ${e}}`);
+
+    const chrome_notes = process.env.CHROME_VERSION_NOTES;
+    if(chrome_notes) {
+      console.error(chrome_notes)
+    } else {
+      console.error("No chrome notes!")
+    }
+
     process.exit(1);
   }
 }

scripts/run_tests_in_ci.js

@@ -91,6 +91,8 @@ const argv = yargs.options({
     const chrome_notes = process.env.CHROME_VERSION_NOTES;
     if(chrome_notes) {
       console.error(chrome_notes)
+    } else {
+      console.error("No chrome notes!")
     }
 
     writeLogs('Failure', name, stdout + '\n' + stderr);