find the matching group the right way

Feiyang1 · Feiyang1 · commit c5f0ef84ec44 · 2020-07-15T18:02:18.000-07:00
diff --git a/repo-scripts/changelog-generator/index.ts b/repo-scripts/changelog-generator/index.ts
@@ -104,7 +104,8 @@ async function getFixedIssueLink(
     return '';
   }
 
-  const issueNumber = match.groups![3];
+  console.log(match);
+  const issueNumber = match[3];
   return `Fixed [#${issueNumber}](https://github.com/firebase/firebase-js-sdk/issues/${issueNumber})`;
 }
 
diff --git a/repo-scripts/changelog-generator/package.json b/repo-scripts/changelog-generator/package.json
@@ -12,6 +12,7 @@
     "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "build": "tsc",
+    "build:dev": "tsc -w",
     "test": "yarn type-check && run-p lint test:browser test:node",
     "test:ci": "node ../../scripts/run_tests_in_ci.js",
     "test:browser": "karma start --single-run",

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,8 @@ async function getFixedIssueLink(`
`104`	`104`	`return '';`
`105`	`105`	`}`
`106`	`106`
`107`		`- const issueNumber = match.groups![3];`
	`107`	`+ console.log(match);`
	`108`	`+ const issueNumber = match[3];`
`108`	`109`	return `Fixed [#${issueNumber}](https://github.com/firebase/firebase-js-sdk/issues/${issueNumber})`;
`109`	`110`	`}`
`110`	`111`