Skip to content

Commit c67bdd9

Browse files
committed
resolve comments
1 parent 52b446a commit c67bdd9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

packages/firestore/src/core/firestore_client.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ export function firestoreClientRunAggregationQuery(
507507
client: FirestoreClient,
508508
query: AggregateQuery
509509
): Promise<AggregateQuerySnapshot> {
510-
return client.asyncQueue.enqueue(async () => {
510+
return client.asyncQueue.enqueue(() => {
511511
return getAggregate(query);
512512
});
513513
}

packages/firestore/src/remote/datastore.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,10 @@ export async function invokeRunAggregationQueryRpc(
247247
queryToTarget(aggregateQuery.query._query)
248248
);
249249

250-
//while invoking streaming RPC, grpc_connection requires parent in the request
251-
//while rest_connection excludes it
250+
/**
251+
* Include the parent in the request for grpc_connection.
252+
* Exclude the parent from request for rest_connection.
253+
*/
252254
const parent = request.parent;
253255
if (!datastoreImpl.connection.shouldResourcePathBeIncludedInRequest) {
254256
delete request.parent;

0 commit comments

Comments
 (0)