Skip to content

Commit c70638d

Browse files
committed
Remove release script changes
1 parent 172f800 commit c70638d

File tree

3 files changed

+5
-35
lines changed

3 files changed

+5
-35
lines changed

packages-exp/firebase-exp/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "firebase-exp",
3-
"version": "0.900.7",
3+
"version": "0.900.8",
44
"private": true,
55
"description": "Firebase JavaScript library for web and Node.js",
66
"author": "Firebase <[email protected]> (https://firebase.google.com/)",

packages/firestore/src/api/database.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,10 @@ export class Firestore
277277
}
278278

279279
terminate(): Promise<void> {
280-
(this.app as _FirebaseApp)._removeServiceInstance('firestore');
281-
(this.app as _FirebaseApp)._removeServiceInstance('firestore-exp');
280+
if (this._appCompat) {
281+
(this._appCompat as _FirebaseApp)._removeServiceInstance('firestore');
282+
(this._appCompat as _FirebaseApp)._removeServiceInstance('firestore-exp');
283+
}
282284
return this._delegate._delete();
283285
}
284286

scripts/exp/release.ts

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -216,26 +216,6 @@ async function buildPackages() {
216216
}
217217
);
218218

219-
// Build app-exp but revert typings
220-
await spawn(
221-
'yarn',
222-
['lerna', 'run', '--scope', '@firebase/app-exp', 'build:release'],
223-
{
224-
cwd: projectRoot,
225-
stdio: 'inherit'
226-
}
227-
);
228-
229-
// Revert app-exp typings to internal
230-
await spawn(
231-
'yarn',
232-
['lerna', 'run', '--scope', '@firebase/app-exp', 'typings:internal'],
233-
{
234-
cwd: projectRoot,
235-
stdio: 'inherit'
236-
}
237-
);
238-
239219
// Build exp and compat packages except for firebase-exp
240220
await spawn(
241221
'yarn',
@@ -246,8 +226,6 @@ async function buildPackages() {
246226
'@firebase/*-exp',
247227
'--scope',
248228
'@firebase/*-compat',
249-
'--ignore',
250-
'@firebase/app-exp',
251229
'build:release'
252230
],
253231
{
@@ -296,16 +274,6 @@ async function buildPackages() {
296274
}
297275
);
298276

299-
// Restore public app-exp typings
300-
await spawn(
301-
'yarn',
302-
['lerna', 'run', '--scope', '@firebase/app-exp', 'typings:public'],
303-
{
304-
cwd: projectRoot,
305-
stdio: 'inherit'
306-
}
307-
);
308-
309277
// remove packages/installations/dist, otherwise packages that depend on packages-exp/installations-exp (e.g. Perf, FCM)
310278
// will incorrectly reference packages/installations.
311279
const installationsDistDirPath = resolve(

0 commit comments

Comments
 (0)