Skip to content

Commit ca4ead2

Browse files
authored
Add storage to Node bundle and Node docs (#5215)
1 parent ea25b2e commit ca4ead2

File tree

5 files changed

+6
-24
lines changed

5 files changed

+6
-24
lines changed

common/api-review/analytics-exp.api.md

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ export interface EventParams {
5959
// (undocumented)
6060
checkout_step?: number;
6161
// (undocumented)
62-
content_id?: string;
63-
// (undocumented)
6462
content_type?: string;
6563
// (undocumented)
6664
coupon?: string;
@@ -77,6 +75,8 @@ export interface EventParams {
7775
firebase_screen?: string;
7876
firebase_screen_class?: string;
7977
// (undocumented)
78+
item_id?: string;
79+
// (undocumented)
8080
item_list_id?: string;
8181
// (undocumented)
8282
item_list_name?: string;
@@ -125,18 +125,12 @@ export interface GtagConfigParams {
125125
// (undocumented)
126126
[key: string]: unknown;
127127
'allow_ad_personalization_signals'?: boolean;
128-
'anonymize_ip'?: boolean;
129128
'cookie_domain'?: string;
130129
'cookie_expires'?: number;
131130
'cookie_flags'?: string;
132131
'cookie_prefix'?: string;
133132
'cookie_update'?: boolean;
134-
'custom_map'?: {
135-
[key: string]: unknown;
136-
};
137-
'link_attribution'?: boolean;
138133
'page_location'?: string;
139-
'page_path'?: string;
140134
'page_title'?: string;
141135
'send_page_view'?: boolean;
142136
}
@@ -262,7 +256,6 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'exception', e
262256
export function logEvent(analyticsInstance: Analytics, eventName: 'generate_lead', eventParams?: {
263257
value?: EventParams['value'];
264258
currency?: EventParams['currency'];
265-
transaction_id?: EventParams['transaction_id'];
266259
[key: string]: any;
267260
}, options?: AnalyticsCallOptions): void;
268261

@@ -295,13 +288,8 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'purchase' | '
295288

296289
// @public
297290
export function logEvent(analyticsInstance: Analytics, eventName: 'screen_view', eventParams?: {
298-
app_name: string;
299-
screen_name: EventParams['screen_name'];
300291
firebase_screen: EventParams['firebase_screen'];
301292
firebase_screen_class: EventParams['firebase_screen_class'];
302-
app_id?: string;
303-
app_version?: string;
304-
app_installer_id?: string;
305293
[key: string]: any;
306294
}, options?: AnalyticsCallOptions): void;
307295

@@ -313,10 +301,8 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'search' | 'vi
313301

314302
// @public
315303
export function logEvent(analyticsInstance: Analytics, eventName: 'select_content', eventParams?: {
316-
items?: EventParams['items'];
317-
promotions?: EventParams['promotions'];
318304
content_type?: EventParams['content_type'];
319-
content_id?: EventParams['content_id'];
305+
item_id?: EventParams['item_id'];
320306
[key: string]: any;
321307
}, options?: AnalyticsCallOptions): void;
322308

@@ -347,7 +333,7 @@ export function logEvent(analyticsInstance: Analytics, eventName: 'set_checkout_
347333
export function logEvent(analyticsInstance: Analytics, eventName: 'share', eventParams?: {
348334
method?: EventParams['method'];
349335
content_type?: EventParams['content_type'];
350-
content_id?: EventParams['content_id'];
336+
item_id?: EventParams['item_id'];
351337
[key: string]: any;
352338
}, options?: AnalyticsCallOptions): void;
353339

packages-exp/firebase-exp/compat/index.d.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7451,9 +7451,6 @@ declare namespace firebase.messaging {
74517451
function isSupported(): boolean;
74527452
}
74537453

7454-
/**
7455-
* @webonly
7456-
*/
74577454
declare namespace firebase.storage {
74587455
/**
74597456
* The full set of object metadata, including read-only properties.

packages-exp/firebase-exp/compat/index.node.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import './auth';
2222
import './database';
2323
import './firestore';
2424
import './functions';
25+
import './storage';
2526

2627
firebase.registerVersion(name, version, 'compat-node');
2728

packages/firebase/index.d.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7499,9 +7499,6 @@ declare namespace firebase.messaging {
74997499
function isSupported(): boolean;
75007500
}
75017501

7502-
/**
7503-
* @webonly
7504-
*/
75057502
declare namespace firebase.storage {
75067503
/**
75077504
* The full set of object metadata, including read-only properties.

packages/firebase/src/index.node.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import '../database';
2323
import '../firestore';
2424
import '../firestore/bundle';
2525
import '../functions';
26+
import '../storage';
2627

2728
firebase.registerVersion(name, version, 'node');
2829

0 commit comments

Comments
 (0)